Skip to content

Commit 8f8ab6f

Browse files
orangemocharvagg
authored andcommitted
test: runner should return 0 on flaky tests
Make the test runner return a 0 exit code when only flaky tests fail and --flaky-tests=dontcare is specified. Ported from nodejs/node-v0.x-archive@a9b642c PR-URL: #2424 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
1 parent 0cfd3be commit 8f8ab6f

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

tools/test.py

+10-3
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,9 @@ def __init__(self, cases, flaky_tests_mode):
7575
self.remaining = len(cases)
7676
self.total = len(cases)
7777
self.failed = [ ]
78+
self.flaky_failed = [ ]
7879
self.crashed = 0
80+
self.flaky_crashed = 0
7981
self.lock = threading.Lock()
8082
self.shutdown_event = threading.Event()
8183

@@ -143,9 +145,14 @@ def RunSingle(self, parallel, thread_id):
143145
return
144146
self.lock.acquire()
145147
if output.UnexpectedOutput():
146-
self.failed.append(output)
147-
if output.HasCrashed():
148-
self.crashed += 1
148+
if FLAKY in output.test.outcomes and self.flaky_tests_mode == DONTCARE:
149+
self.flaky_failed.append(output)
150+
if output.HasCrashed():
151+
self.flaky_crashed += 1
152+
else:
153+
self.failed.append(output)
154+
if output.HasCrashed():
155+
self.crashed += 1
149156
else:
150157
self.succeeded += 1
151158
self.remaining -= 1

0 commit comments

Comments
 (0)