Skip to content

Commit 8bd80f4

Browse files
committed
fix test-sys for hash randomization
broken in 4a899c9
1 parent 4a899c9 commit 8bd80f4

File tree

1 file changed

+21
-9
lines changed

1 file changed

+21
-9
lines changed

test/simple/test-sys.js

+21-9
Original file line numberDiff line numberDiff line change
@@ -60,17 +60,29 @@ assert.equal('{ visible: 1 }',
6060
common.inspect(Object.create({},
6161
{visible: {value: 1, enumerable: true}, hidden: {value: 2}}))
6262
);
63-
assert.equal('{ [hidden]: 2, visible: 1 }',
64-
common.inspect(Object.create({},
65-
{visible: {value: 1, enumerable: true}, hidden: {value: 2}}), true)
66-
);
63+
64+
// Due to the hash seed randomization it's not deterministic the order that
65+
// the following ways this hash is displayed.
66+
// See http://codereview.chromium.org/9124004/
67+
68+
var out = common.inspect(Object.create({},
69+
{visible: {value: 1, enumerable: true}, hidden: {value: 2}}), true);
70+
if (out !== '{ [hidden]: 2, visible: 1 }' &&
71+
out !== '{ visible: 1, [hidden]: 2 }') {
72+
assert.ok(false);
73+
}
74+
6775

6876
// Objects without prototype
69-
assert.equal('{ [hidden]: \'secret\', name: \'Tim\' }',
70-
common.inspect(Object.create(null,
71-
{name: {value: 'Tim', enumerable: true},
72-
hidden: {value: 'secret'}}), true)
73-
);
77+
var out = common.inspect(Object.create(null,
78+
{ name: {value: 'Tim', enumerable: true},
79+
hidden: {value: 'secret'}}), true);
80+
if (out !== "{ [hidden]: 'secret', name: 'Tim' }" &&
81+
out !== "{ name: 'Tim', [hidden]: 'secret' }") {
82+
assert(false);
83+
}
84+
85+
7486
assert.equal('{ name: \'Tim\' }',
7587
common.inspect(Object.create(null,
7688
{name: {value: 'Tim', enumerable: true},

0 commit comments

Comments
 (0)