Skip to content

Commit 88d7904

Browse files
committed
test: remove test repetition
Remove loops executing the same tests multiple times. PR-URL: #1874 Reviewed-By: Trevor Norris <[email protected]>
1 parent 4285265 commit 88d7904

File tree

1 file changed

+21
-25
lines changed

1 file changed

+21
-25
lines changed

test/parallel/test-buffer.js

+21-25
Original file line numberDiff line numberDiff line change
@@ -271,35 +271,31 @@ assert.equal(writeTest.toString(), 'nodejs');
271271

272272
var asciiString = 'hello world';
273273
var offset = 100;
274-
for (var j = 0; j < 500; j++) {
275274

276-
for (var i = 0; i < asciiString.length; i++) {
277-
b[i] = asciiString.charCodeAt(i);
278-
}
279-
var asciiSlice = b.toString('ascii', 0, asciiString.length);
280-
assert.equal(asciiString, asciiSlice);
281-
282-
var written = b.write(asciiString, offset, 'ascii');
283-
assert.equal(asciiString.length, written);
284-
var asciiSlice = b.toString('ascii', offset, offset + asciiString.length);
285-
assert.equal(asciiString, asciiSlice);
286-
287-
var sliceA = b.slice(offset, offset + asciiString.length);
288-
var sliceB = b.slice(offset, offset + asciiString.length);
289-
for (var i = 0; i < asciiString.length; i++) {
290-
assert.equal(sliceA[i], sliceB[i]);
291-
}
292-
293-
// TODO utf8 slice tests
275+
for (var i = 0; i < asciiString.length; i++) {
276+
b[i] = asciiString.charCodeAt(i);
277+
}
278+
var asciiSlice = b.toString('ascii', 0, asciiString.length);
279+
assert.equal(asciiString, asciiSlice);
280+
281+
var written = b.write(asciiString, offset, 'ascii');
282+
assert.equal(asciiString.length, written);
283+
var asciiSlice = b.toString('ascii', offset, offset + asciiString.length);
284+
assert.equal(asciiString, asciiSlice);
285+
286+
var sliceA = b.slice(offset, offset + asciiString.length);
287+
var sliceB = b.slice(offset, offset + asciiString.length);
288+
for (var i = 0; i < asciiString.length; i++) {
289+
assert.equal(sliceA[i], sliceB[i]);
294290
}
295291

292+
// TODO utf8 slice tests
296293

297-
for (var j = 0; j < 100; j++) {
298-
var slice = b.slice(100, 150);
299-
assert.equal(50, slice.length);
300-
for (var i = 0; i < 50; i++) {
301-
assert.equal(b[100 + i], slice[i]);
302-
}
294+
295+
var slice = b.slice(100, 150);
296+
assert.equal(50, slice.length);
297+
for (var i = 0; i < 50; i++) {
298+
assert.equal(b[100 + i], slice[i]);
303299
}
304300

305301

0 commit comments

Comments
 (0)