Skip to content

Commit 86a6478

Browse files
bnoordhuisitaloacasas
authored andcommitted
build: don't rebuild test/gc add-on unnecessarily
Remove the explicit dependency on $(NODE_EXE), it always triggers a rebuild due to it being a .PHONY rule. Add-ons in test/addons/ have the same implicit dependency so it isn't completely without precedent. PR-URL: #11311 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
1 parent 18599fc commit 86a6478

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Makefile

+4-2
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,10 @@ test-parallel: all
133133
test-valgrind: all
134134
$(PYTHON) tools/test.py --mode=release --valgrind sequential parallel message
135135

136-
test/gc/build/Release/binding.node: \
137-
$(NODE_EXE) test/gc/binding.cc test/gc/binding.gyp
136+
# Implicitly depends on $(NODE_EXE). We don't depend on it explicitly because
137+
# it always triggers a rebuild due to it being a .PHONY rule. See the comment
138+
# near the build-addons rule for more background.
139+
test/gc/build/Release/binding.node: test/gc/binding.cc test/gc/binding.gyp
138140
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
139141
--python="$(PYTHON)" \
140142
--directory="$(shell pwd)/test/gc" \

0 commit comments

Comments
 (0)