Skip to content

Commit 7a272d9

Browse files
thughesry
authored andcommitted
cmake: explicitly disable fdatasync when building for OSX.
This ensures that the check_function_exists() for fdatasync in the libeio CMakeLists.txt is not run, since that fails on some versions of OSX (http://public.kitware.com/Bug/view.php?id=10044).
1 parent db6ea10 commit 7a272d9

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

cmake/configure.cmake

+2
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ endif()
6161

6262
if(${node_platform} MATCHES darwin)
6363
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -framework Carbon")
64+
# explicitly set this so that we don't check again when building libeio
65+
set(HAVE_FDATASYNC 0)
6466
else()
6567
# OSX fdatasync() check wrong: http://public.kitware.com/Bug/view.php?id=10044
6668
check_function_exists(fdatasync HAVE_FDATASYNC)

0 commit comments

Comments
 (0)