Skip to content

Commit 7554612

Browse files
indutnychrisdickinson
authored andcommitted
tls: fix typo handle._reading => handle.reading
The problem does not manifest itself on unixes, because `uv_read_start()` always return 0 there. However on Windows on a second call `uv_read_start()` returns `UV__EALREADY` destroying all sockets on a read attempt. Set `.reading` property that is already handled by `net.js` code. Fix: #988 PR-URL: #994 Reviewed-By: Chris Dickinson <[email protected]>
1 parent 675cffb commit 7554612

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/_tls_wrap.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ TLSSocket.prototype._wrapHandle = function(handle) {
281281
tls.createSecureContext();
282282
res = tls_wrap.wrap(handle, context.context, options.isServer);
283283
res._parent = handle;
284-
res._reading = handle._reading;
284+
res.reading = handle.reading;
285285

286286
// Proxy HandleWrap, PipeWrap and TCPWrap methods
287287
proxiedMethods.forEach(function(name) {

0 commit comments

Comments
 (0)