Skip to content

Commit 678d671

Browse files
committed
deps: silence irrelevant V8 warnings
PR-URL: #37587 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>
1 parent 1b68667 commit 678d671

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.5',
39+
'v8_embedder_string': '-node.6',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8-callbacks.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,7 @@ using AddHistogramSampleCallback = void (*)(void* histogram, int sample);
230230
* fails (e.g. due to stack overflow), the embedder must propagate
231231
* that exception by returning an empty MaybeLocal.
232232
*/
233-
using HostImportModuleDynamicallyCallback V8_DEPRECATED(
234-
"Use HostImportModuleDynamicallyWithImportAssertionsCallback instead") =
233+
using HostImportModuleDynamicallyCallback =
235234
MaybeLocal<Promise> (*)(Local<Context> context,
236235
Local<ScriptOrModule> referrer,
237236
Local<String> specifier);

deps/v8/include/v8-script.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ class V8_EXPORT Module : public Data {
209209
*/
210210
int GetIdentityHash() const;
211211

212-
using ResolveCallback V8_DEPRECATE_SOON("Use ResolveModuleCallback") =
212+
using ResolveCallback =
213213
MaybeLocal<Module> (*)(Local<Context> context, Local<String> specifier,
214214
Local<Module> referrer);
215215
using ResolveModuleCallback = MaybeLocal<Module> (*)(

0 commit comments

Comments
 (0)