Skip to content

Commit 66c57a2

Browse files
hiroppyitaloacasas
authored andcommitted
test: add test case to test-http-response-statuscode.js
Change regular expression of error message. Add test case(`res.writeHead()`). PR-URL: #10808 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 9a111e7 commit 66c57a2

File tree

1 file changed

+22
-13
lines changed

1 file changed

+22
-13
lines changed

test/parallel/test-http-response-statuscode.js

+22-13
Original file line numberDiff line numberDiff line change
@@ -3,70 +3,79 @@ const common = require('../common');
33
const assert = require('assert');
44
const http = require('http');
55

6-
const MAX_REQUESTS = 12;
6+
const MAX_REQUESTS = 13;
77
let reqNum = 0;
88

9+
const createErrorMessage = (code) => {
10+
return new RegExp(`^RangeError: Invalid status code: ${code}$`);
11+
};
12+
913
const server = http.Server(common.mustCall(function(req, res) {
1014
switch (reqNum) {
1115
case 0:
1216
assert.throws(common.mustCall(() => {
1317
res.writeHead(-1);
14-
}), /invalid status code/i);
18+
}), createErrorMessage(-1));
1519
break;
1620
case 1:
1721
assert.throws(common.mustCall(() => {
1822
res.writeHead(Infinity);
19-
}), /invalid status code/i);
23+
}), createErrorMessage(0));
2024
break;
2125
case 2:
2226
assert.throws(common.mustCall(() => {
2327
res.writeHead(NaN);
24-
}), /invalid status code/i);
28+
}), createErrorMessage(0));
2529
break;
2630
case 3:
2731
assert.throws(common.mustCall(() => {
2832
res.writeHead({});
29-
}), /invalid status code/i);
33+
}), createErrorMessage(0));
3034
break;
3135
case 4:
3236
assert.throws(common.mustCall(() => {
3337
res.writeHead(99);
34-
}), /invalid status code/i);
38+
}), createErrorMessage(99));
3539
break;
3640
case 5:
3741
assert.throws(common.mustCall(() => {
3842
res.writeHead(1000);
39-
}), /invalid status code/i);
43+
}), createErrorMessage(1000));
4044
break;
4145
case 6:
4246
assert.throws(common.mustCall(() => {
4347
res.writeHead('1000');
44-
}), /invalid status code/i);
48+
}), createErrorMessage(1000));
4549
break;
4650
case 7:
4751
assert.throws(common.mustCall(() => {
4852
res.writeHead(null);
49-
}), /invalid status code/i);
53+
}), createErrorMessage(0));
5054
break;
5155
case 8:
5256
assert.throws(common.mustCall(() => {
5357
res.writeHead(true);
54-
}), /invalid status code/i);
58+
}), createErrorMessage(1));
5559
break;
5660
case 9:
5761
assert.throws(common.mustCall(() => {
5862
res.writeHead([]);
59-
}), /invalid status code/i);
63+
}), createErrorMessage(0));
6064
break;
6165
case 10:
6266
assert.throws(common.mustCall(() => {
6367
res.writeHead('this is not valid');
64-
}), /invalid status code/i);
68+
}), createErrorMessage(0));
6569
break;
6670
case 11:
6771
assert.throws(common.mustCall(() => {
6872
res.writeHead('404 this is not valid either');
69-
}), /invalid status code/i);
73+
}), createErrorMessage(0));
74+
break;
75+
case 12:
76+
assert.throws(common.mustCall(() => {
77+
res.writeHead();
78+
}), createErrorMessage(0));
7079
this.close();
7180
break;
7281
default:

0 commit comments

Comments
 (0)