Skip to content

Commit 573cafe

Browse files
Trottruyadorno
authored andcommitted
test: remove eslint-disable comments from fixtures
We do not lint the fixtures code so eslint-disable comments are superfluous. PR-URL: #41859 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent f8acca8 commit 573cafe

File tree

7 files changed

+0
-8
lines changed

7 files changed

+0
-8
lines changed

test/fixtures/es-module-loaders/loader-invalid-url.mjs

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable node-core/required-modules */
21
export async function resolve(specifier, { parentURL, importAssertions }, defaultResolve) {
32
if (parentURL && specifier === '../fixtures/es-modules/test-esm-ok.mjs') {
43
return {
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
'use strict';
2-
/* eslint-disable node-core/required-modules */
32

43
throw undefined;
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
/* eslint-disable no-unused-vars */
21
import { ofLife } from '../experimental.json' assert { type: 'json' };

test/fixtures/wpt/streams/readable-streams/general.any.js

-1
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,6 @@ promise_test(() => {
630630
let pullCalled = 0;
631631
let cancelCalled = 0;
632632

633-
/* eslint-disable no-use-before-define */
634633
class Source {
635634
start(c) {
636635
startCalled++;

test/fixtures/wpt/streams/readable-streams/patched-global.any.js

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ test(t => {
2222

2323
const trappedProperties = ['highWaterMark', 'size', 'start', 'type', 'mode'];
2424
for (const property of trappedProperties) {
25-
// eslint-disable-next-line no-extend-native, accessor-pairs
2625
Object.defineProperty(Object.prototype, property, {
2726
get() { throw new Error(`${property} getter called`); },
2827
configurable: true

test/fixtures/wpt/streams/resources/test-utils.js

-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ self.garbageCollect = () => {
5757
// Present in some WebKit development environments
5858
GCController.collect();
5959
} else {
60-
/* eslint-disable no-console */
6160
console.warn('Tests are running without the ability to do manual garbage collection. They will still work, but ' +
6261
'coverage will be suboptimal.');
6362
/* eslint-enable no-console */

test/fixtures/wpt/streams/transform-streams/patched-global.any.js

-2
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,11 @@
55
// interfering with other tests.
66

77
test(t => {
8-
// eslint-disable-next-line no-extend-native, accessor-pairs
98
Object.defineProperty(Object.prototype, 'highWaterMark', {
109
set() { throw new Error('highWaterMark setter called'); },
1110
configurable: true
1211
});
1312

14-
// eslint-disable-next-line no-extend-native, accessor-pairs
1513
Object.defineProperty(Object.prototype, 'size', {
1614
set() { throw new Error('size setter called'); },
1715
configurable: true

0 commit comments

Comments
 (0)