Skip to content

Commit 54e55e0

Browse files
targositaloacasas
authored andcommitted
test: make test-intl-no-icu-data more robust
In V8 5.6, String#toLocaleUpperCase can work even when no ICU data is loaded. Use another method to check the --icu-data-dir option pointing to an empty directory. PR-URL: #10992 Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 7b253eb commit 54e55e0

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

test/parallel/test-intl-no-icu-data.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,5 @@ require('../common');
44
const assert = require('assert');
55
const config = process.binding('config');
66

7-
// No-op when ICU case mappings are unavailable.
8-
assert.strictEqual('ç'.toLocaleUpperCase('el'), 'ç');
7+
assert.deepStrictEqual(Intl.NumberFormat.supportedLocalesOf('en'), []);
98
assert.strictEqual(config.icuDataDir, 'test/fixtures/empty/');

0 commit comments

Comments
 (0)