Skip to content

Commit 525544b

Browse files
committed
test: remove harmony flags
v8 6.8 supports all removed flags. For example for BigInt. PR-URL: #22285 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 6bba368 commit 525544b

7 files changed

+12
-29
lines changed

doc/api/util.md

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1021,10 +1021,7 @@ added: v10.0.0
10211021
* `value` {any}
10221022
* Returns: {boolean}
10231023

1024-
Returns `true` if the value is a `BigInt64Array` instance. The
1025-
`--harmony-bigint` command line flag is required in order to use the
1026-
`BigInt64Array` type, but it is not required in order to use
1027-
`isBigInt64Array()`.
1024+
Returns `true` if the value is a `BigInt64Array` instance.
10281025

10291026
For example:
10301027

@@ -1041,10 +1038,7 @@ added: v10.0.0
10411038
* `value` {any}
10421039
* Returns: {boolean}
10431040

1044-
Returns `true` if the value is a `BigUint64Array` instance. The
1045-
`--harmony-bigint` command line flag is required in order to use the
1046-
`BigUint64Array` type, but it is not required in order to use
1047-
`isBigUint64Array()`.
1041+
Returns `true` if the value is a `BigUint64Array` instance.
10481042

10491043
For example:
10501044

src/node.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2962,10 +2962,6 @@ static void ParseArgs(int* argc,
29622962
config_preserve_symlinks_main = true;
29632963
} else if (strcmp(arg, "--experimental-modules") == 0) {
29642964
config_experimental_modules = true;
2965-
new_v8_argv[new_v8_argc] = "--harmony-dynamic-import";
2966-
new_v8_argc += 1;
2967-
new_v8_argv[new_v8_argc] = "--harmony-import-meta";
2968-
new_v8_argc += 1;
29692965
} else if (strcmp(arg, "--experimental-vm-modules") == 0) {
29702966
config_experimental_vm_modules = true;
29712967
} else if (strcmp(arg, "--experimental-worker") == 0) {

test/parallel/test-util-inspect-bigint.js

Lines changed: 0 additions & 14 deletions
This file was deleted.

test/parallel/test-util-inspect.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ const JSStream = process.binding('js_stream').JSStream;
2626
const util = require('util');
2727
const vm = require('vm');
2828
const { previewEntries } = process.binding('util');
29+
const { inspect } = util;
2930

3031
assert.strictEqual(util.inspect(1), '1');
3132
assert.strictEqual(util.inspect(false), 'false');
@@ -1629,3 +1630,9 @@ assert.strictEqual(util.inspect('"\'${a}'), "'\"\\'${a}'");
16291630
value.foo = 'bar';
16301631
assert.notStrictEqual(util.inspect(value), expected);
16311632
});
1633+
1634+
assert.strictEqual(inspect(1n), '1n');
1635+
assert.strictEqual(inspect(Object(-1n)), '[BigInt: -1n]');
1636+
assert.strictEqual(inspect(Object(13n)), '[BigInt: 13n]');
1637+
assert.strictEqual(inspect(new BigInt64Array([0n])), 'BigInt64Array [ 0n ]');
1638+
assert.strictEqual(inspect(new BigUint64Array([0n])), 'BigUint64Array [ 0n ]');

test/parallel/test-util-types.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Flags: --harmony-bigint --experimental-vm-modules
1+
// Flags: --experimental-vm-modules
22
'use strict';
33
require('../common');
44
const fixtures = require('../common/fixtures');

test/parallel/test-vm-module-dynamic-import.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
// Flags: --experimental-vm-modules --experimental-modules --harmony-dynamic-import
3+
// Flags: --experimental-vm-modules --experimental-modules
44

55
const common = require('../common');
66

test/parallel/test-vm-module-import-meta.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22

3-
// Flags: --experimental-vm-modules --harmony-import-meta
3+
// Flags: --experimental-vm-modules
44

55
const common = require('../common');
66
const assert = require('assert');

0 commit comments

Comments
 (0)