Skip to content

Commit 4b8629d

Browse files
committed
v8: remove optimization switches
Remove compiler switches from $(TOPLEVEL)/deps/v8/build/common.gypi, we set them globally in $(TOPLEVEL)/common.gypi. Commit 29d12c7 accidentally reintroduced the switches again. In particular, the 'cflags!': ['-O2','-Os'] section forced building V8 without any optimizations, resulting in a steep (~66%) performance drop on some benchmarks. Fixes #4191.
1 parent 28e6403 commit 4b8629d

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

deps/v8/build/common.gypi

-10
Original file line numberDiff line numberDiff line change
@@ -339,16 +339,6 @@
339339
'conditions': [
340340
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd" \
341341
or OS=="android"', {
342-
'cflags!': [
343-
'-O2',
344-
'-Os',
345-
],
346-
'cflags': [
347-
'-fdata-sections',
348-
'-ffunction-sections',
349-
'-fomit-frame-pointer',
350-
'-O3',
351-
],
352342
'conditions': [
353343
[ 'gcc_version==44 and clang==0', {
354344
'cflags': [

0 commit comments

Comments
 (0)