Skip to content

Commit 3abfb56

Browse files
yosuke-furukawabnoordhuis
authored andcommitted
benchmark: fix tcp bench after internal api change
Fix up the tcp raw benchmarks after an internal API change. PR-URL: #495 Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 50177fb commit 3abfb56

File tree

3 files changed

+21
-10
lines changed

3 files changed

+21
-10
lines changed

benchmark/net/tcp-raw-c2s.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ var bench = common.createBenchmark(main, {
1414
});
1515

1616
var TCP = process.binding('tcp_wrap').TCP;
17+
var TCPConnectWrap = process.binding('tcp_wrap').TCPConnectWrap;
18+
var WriteWrap = process.binding('stream_wrap').WriteWrap;
1719
var PORT = common.PORT;
1820

1921
var dur;
@@ -91,7 +93,7 @@ function client() {
9193
}
9294

9395
var clientHandle = new TCP();
94-
var connectReq = {};
96+
var connectReq = new TCPConnectWrap();
9597
var err = clientHandle.connect(connectReq, '127.0.0.1', PORT);
9698

9799
if (err)
@@ -108,7 +110,8 @@ function client() {
108110
};
109111

110112
function write() {
111-
var writeReq = { oncomplete: afterWrite };
113+
var writeReq = new WriteWrap();
114+
writeReq.oncomplete = afterWrite;
112115
var err;
113116
switch (type) {
114117
case 'buf':

benchmark/net/tcp-raw-pipe.js

+9-5
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ var bench = common.createBenchmark(main, {
1414
});
1515

1616
var TCP = process.binding('tcp_wrap').TCP;
17+
var TCPConnectWrap = process.binding('tcp_wrap').TCPConnectWrap;
18+
var WriteWrap = process.binding('stream_wrap').WriteWrap;
1719
var PORT = common.PORT;
1820

1921
var dur;
@@ -51,14 +53,15 @@ function server() {
5153
if (nread < 0)
5254
fail(nread, 'read');
5355

54-
var writeReq = { async: false };
56+
var writeReq = new WriteWrap();
57+
writeReq.async = false;
5558
err = clientHandle.writeBuffer(writeReq, buffer);
5659

5760
if (err)
5861
fail(err, 'write');
5962

60-
writeReq.oncomplete = function(status, handle, req) {
61-
if (status)
63+
writeReq.oncomplete = function(status, handle, req, err) {
64+
if (err)
6265
fail(err, 'write');
6366
};
6467
};
@@ -88,7 +91,7 @@ function client() {
8891
}
8992

9093
var clientHandle = new TCP();
91-
var connectReq = {};
94+
var connectReq = new TCPConnectWrap();
9295
var err = clientHandle.connect(connectReq, '127.0.0.1', PORT);
9396
var bytes = 0;
9497

@@ -121,7 +124,8 @@ function client() {
121124
};
122125

123126
function write() {
124-
var writeReq = { oncomplete: afterWrite };
127+
var writeReq = new WriteWrap();
128+
writeReq.oncomplete = afterWrite;
125129
var err;
126130
switch (type) {
127131
case 'buf':

benchmark/net/tcp-raw-s2c.js

+7-3
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ var bench = common.createBenchmark(main, {
1414
});
1515

1616
var TCP = process.binding('tcp_wrap').TCP;
17+
var TCPConnectWrap = process.binding('tcp_wrap').TCPConnectWrap;
18+
var WriteWrap = process.binding('stream_wrap').WriteWrap;
1719
var PORT = common.PORT;
1820

1921
var dur;
@@ -68,7 +70,9 @@ function server() {
6870
write();
6971

7072
function write() {
71-
var writeReq = { async: false, oncomplete: afterWrite };
73+
var writeReq = new WriteWrap();
74+
writeReq.async = false;
75+
writeReq.oncomplete = afterWrite;
7276
var err;
7377
switch (type) {
7478
case 'buf':
@@ -91,7 +95,7 @@ function server() {
9195
}
9296
}
9397

94-
function afterWrite(err, handle, req) {
98+
function afterWrite(status, handle, req, err) {
9599
if (err)
96100
fail(err, 'write');
97101

@@ -105,7 +109,7 @@ function server() {
105109

106110
function client() {
107111
var clientHandle = new TCP();
108-
var connectReq = {};
112+
var connectReq = new TCPConnectWrap();
109113
var err = clientHandle.connect(connectReq, '127.0.0.1', PORT);
110114

111115
if (err)

0 commit comments

Comments
 (0)