Skip to content

Commit 38fd790

Browse files
committed
tty: fix console printing on Windows
This broke writing non-ASCII data to the console on Windows because the result would be codepage-dependent. This partially reverts 8b751f7. Fixes: #18189 Refs: #18019 PR-URL: #18214 Fixes: #18189 Refs: #18019 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent f607577 commit 38fd790

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

lib/tty.js

-3
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
const util = require('util');
2525
const net = require('net');
2626
const { TTY, isTTY } = process.binding('tty_wrap');
27-
const { makeSyncWrite } = require('internal/net');
2827
const { inherits } = util;
2928
const errnoException = util._errnoException;
3029
const errors = require('internal/errors');
@@ -80,8 +79,6 @@ function WriteStream(fd) {
8079
// even though it was originally intended to change in v1.0.2 (Libuv 1.2.1).
8180
// Ref: https://github.com/nodejs/node/pull/1771#issuecomment-119351671
8281
this._handle.setBlocking(true);
83-
this._writev = null;
84-
this._write = makeSyncWrite(fd);
8582

8683
var winSize = new Array(2);
8784
var err = this._handle.getWindowSize(winSize);

0 commit comments

Comments
 (0)