Skip to content

Commit 34de901

Browse files
evanlucasrvagg
authored andcommitted
build: only define NODE_V8_OPTIONS if not empty
Previously, V8::SetFlagsFromString was called on every launch even if NODE_V8_OPTIONS was an empty string. This patch only defines NODE_V8_OPTIONS if node_v8_options is not an empty string. PR-URL: #2532 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
1 parent 0db0e53 commit 34de901

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

node.gyp

+3-1
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@
179179
'defines': [
180180
'NODE_ARCH="<(target_arch)"',
181181
'NODE_PLATFORM="<(OS)"',
182-
'NODE_V8_OPTIONS="<(node_v8_options)"',
183182
'NODE_WANT_INTERNALS=1',
184183
],
185184

@@ -188,6 +187,9 @@
188187
[ 'node_tag!=""', {
189188
'defines': [ 'NODE_TAG="<(node_tag)"' ],
190189
}],
190+
[ 'node_v8_options!=""', {
191+
'defines': [ 'NODE_V8_OPTIONS="<(node_v8_options)"'],
192+
}],
191193
# No node_main.cc for anything except executable
192194
[ 'node_target_type!="executable"', {
193195
'sources!': [

0 commit comments

Comments
 (0)