Skip to content

Commit 34ba631

Browse files
targosnodejs-github-bot
authored andcommitted
deps: V8: cherry-pick e7f0f26f5ef3
Original commit message: Don't run sampling-heap-profiler-flags with stress-incremental-marking This test observes GC behavior and needs the garbage collector to work in a somewhat predictable way. Bug: v8:13286 Change-Id: I24e6a4f33a644b5f1845cd34558da03fc196f7e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3898721 Commit-Queue: Seth Brenith <[email protected]> Reviewed-by: Simon Zünd <[email protected]> Cr-Commit-Position: refs/heads/main@{#83218} Refs: v8/v8@e7f0f26 PR-URL: #44958 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent 690a837 commit 34ba631

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.13',
39+
'v8_embedder_string': '-node.14',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/test/inspector/heap-profiler/sampling-heap-profiler-flags.js

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
// found in the LICENSE file.
44

55
// Flags: --sampling-heap-profiler-suppress-randomness
6+
// Flags: --no-stress-incremental-marking
67

78
(async function() {
89
let {contextGroup, Protocol} = InspectorTest.start('Checks sampling heap profiler methods.');

0 commit comments

Comments
 (0)