Skip to content

Commit 2fb8257

Browse files
Trottaddaleax
authored andcommitted
test: fix flaky test-inspector
Using `socket.destroy()` instead of `socket.end()` fixes more-than-intermittent ECONNRESET issues on Windows. PR-URL: #9727 Fixes: #8804 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]>
1 parent fc13cc6 commit 2fb8257

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

test/inspector/inspector-helper.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ TestSession.prototype.disconnect = function(childDone) {
286286
this.expectClose_ = true;
287287
this.harness_.childInstanceDone =
288288
this.harness_.childInstanceDone || childDone;
289-
this.socket_.end();
289+
this.socket_.destroy();
290290
console.log('[test]', 'Connection terminated');
291291
callback();
292292
});

test/inspector/inspector.status

-1
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,3 @@ prefix inspector
77
[true] # This section applies to all platforms
88

99
[$system==win32]
10-
test-inspector : PASS,FLAKY

0 commit comments

Comments
 (0)