fs: ensure options.flag defaults to 'r' in readFile

When passing {} or { encoding: 'utf8' } as options to readFile, the
flag is not defaulted to 'r' unlike normal fs. This fix makes
fs.promises.readFile() act consistent with fs.readFile().

It also fixes another issue with fs.promises.readfile() where it
returned a Buffer instead of an empty string when encoding is provided.

PR-URL: #20268
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ron Korving <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>

Author: bdistin

lib/internal/fs/promises.js

@@ -138,7 +138,7 @@ async function readFileHandle(filehandle, options) {
   }
 
   if (size === 0)
-    return Buffer.alloc(0);
+    return options.encoding ? '' : Buffer.alloc(0);
 
   if (size > kMaxLength)
     throw new ERR_FS_FILE_TOO_LARGE(size);
@@ -454,11 +454,12 @@ async function appendFile(path, data, options) {
 
 async function readFile(path, options) {
   options = getOptions(options, { flag: 'r' });
+  const flag = options.flag || 'r';
 
   if (path instanceof FileHandle)
     return readFileHandle(path, options);
 
-  const fd = await open(path, options.flag, 0o666);
+  const fd = await open(path, flag, 0o666);
   return readFileHandle(fd, options).finally(fd.close.bind(fd));
 }
 

test/parallel/test-fs-promises-readfile-empty.js

@@ -0,0 +1,19 @@
+'use strict';
+const common = require('../common');
+
+const assert = require('assert');
+const { promises: fs } = require('fs');
+const fixtures = require('../common/fixtures');
+
+const fn = fixtures.path('empty.txt');
+
+common.crashOnUnhandledRejection();
+
+fs.readFile(fn)
+  .then(assert.ok);
+
+fs.readFile(fn, 'utf8')
+  .then(assert.strictEqual.bind(this, ''));
+
+fs.readFile(fn, { encoding: 'utf8' })
+  .then(assert.strictEqual.bind(this, ''));

test/parallel/test-fs-readfile-empty.js

@@ -38,5 +38,9 @@ fs.readFile(fn, 'utf8', function(err, data) {
   assert.strictEqual('', data);
 });
 
+fs.readFile(fn, { encoding: 'utf8' }, function(err, data) {
+  assert.strictEqual('', data);
+});
+
 assert.ok(fs.readFileSync(fn));
 assert.strictEqual('', fs.readFileSync(fn, 'utf8'));