Skip to content

Commit 2b8b224

Browse files
DeeDeeGbengl
authored andcommitted
doc: remove outdated footnote (Python 2 --> 3 for V8 tests)
Various Python 3 compatibility fixes were made in upstream V8, and they have even dropped Python 2 compatibility in various scripts. depot_tools, which bootstraps the V8 build, is also moving to Python 3. As of Node v18.0.0-ish, this footnote is no-longer accurate. (Running `make test-v8` no-longer requires Python 2, and it won't work anymore if you don't have a copy of Python 3.) PR-URL: #43105 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Jackson Tian <[email protected]>
1 parent ed352a9 commit 2b8b224

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

doc/contributing/maintaining-V8.md

+2-4
Original file line numberDiff line numberDiff line change
@@ -407,10 +407,8 @@ This would require some tooling to:
407407
[^1]: Node.js 0.12 and older are intentionally omitted from this document
408408
as their support has ended.
409409

410-
[^2]: The V8 tests still require Python 2. To run these tests locally, you can
411-
run `PYTHON2 ./configure.py` before running `make test-v8`, in the root
412-
of this repository. On macOS, this also requires a full Xcode install,
413-
not just the "command line tools" for Xcode.
410+
[^2]: On macOS, the V8 tests require a full Xcode install, not just the "command
411+
line tools" for Xcode.
414412

415413
[ChromiumReleaseCalendar]: https://www.chromium.org/developers/calendar
416414
[Node.js CI]: https://ci.nodejs.org/job/node-test-pull-request/

0 commit comments

Comments
 (0)