Skip to content

Commit 19a70c1

Browse files
backestargos
authored andcommitted
src: override CreateJob instead of PostJob
PostJob will call out to CreateJob in its default implementation, so it's sufficient to only override CreateJob. PR-URL: #44741 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 2e49b99 commit 19a70c1

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/node_platform.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -519,8 +519,8 @@ bool NodePlatform::FlushForegroundTasks(Isolate* isolate) {
519519
return per_isolate->FlushForegroundTasksInternal();
520520
}
521521

522-
std::unique_ptr<v8::JobHandle> NodePlatform::PostJob(v8::TaskPriority priority,
523-
std::unique_ptr<v8::JobTask> job_task) {
522+
std::unique_ptr<v8::JobHandle> NodePlatform::CreateJob(
523+
v8::TaskPriority priority, std::unique_ptr<v8::JobTask> job_task) {
524524
return v8::platform::NewDefaultJobHandle(
525525
this, priority, std::move(job_task), NumberOfWorkerThreads());
526526
}

src/node_platform.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ class NodePlatform : public MultiIsolatePlatform {
155155
double CurrentClockTimeMillis() override;
156156
v8::TracingController* GetTracingController() override;
157157
bool FlushForegroundTasks(v8::Isolate* isolate) override;
158-
std::unique_ptr<v8::JobHandle> PostJob(
158+
std::unique_ptr<v8::JobHandle> CreateJob(
159159
v8::TaskPriority priority,
160160
std::unique_ptr<v8::JobTask> job_task) override;
161161

0 commit comments

Comments
 (0)