test: improve test-event-emitter-modify-in-emit

* use let instead of var
* use assert.strictEqual instead of assert.equal
* swap assertions arguments to match the standard

PR-URL: #10600
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: edsadr

test/parallel/test-event-emitter-modify-in-emit.js

@@ -3,7 +3,7 @@ require('../common');
 const assert = require('assert');
 const events = require('events');
 
-var callbacks_called = [];
+let callbacks_called = [];
 
 const e = new events.EventEmitter();
 
@@ -25,35 +25,35 @@ function callback3() {
 }
 
 e.on('foo', callback1);
-assert.equal(1, e.listeners('foo').length);
+assert.strictEqual(e.listeners('foo').length, 1);
 
 e.emit('foo');
-assert.equal(2, e.listeners('foo').length);
+assert.strictEqual(e.listeners('foo').length, 2);
 assert.deepStrictEqual(['callback1'], callbacks_called);
 
 e.emit('foo');
-assert.equal(0, e.listeners('foo').length);
+assert.strictEqual(e.listeners('foo').length, 0);
 assert.deepStrictEqual(['callback1', 'callback2', 'callback3'],
                        callbacks_called);
 
 e.emit('foo');
-assert.equal(0, e.listeners('foo').length);
+assert.strictEqual(e.listeners('foo').length, 0);
 assert.deepStrictEqual(['callback1', 'callback2', 'callback3'],
                        callbacks_called);
 
 e.on('foo', callback1);
 e.on('foo', callback2);
-assert.equal(2, e.listeners('foo').length);
+assert.strictEqual(e.listeners('foo').length, 2);
 e.removeAllListeners('foo');
-assert.equal(0, e.listeners('foo').length);
+assert.strictEqual(e.listeners('foo').length, 0);
 
 // Verify that removing callbacks while in emit allows emits to propagate to
 // all listeners
 callbacks_called = [];
 
 e.on('foo', callback2);
 e.on('foo', callback3);
-assert.equal(2, e.listeners('foo').length);
+assert.strictEqual(2, e.listeners('foo').length);
 e.emit('foo');
 assert.deepStrictEqual(['callback2', 'callback3'], callbacks_called);
-assert.equal(0, e.listeners('foo').length);
+assert.strictEqual(0, e.listeners('foo').length);