Skip to content

Commit 05e6ec0

Browse files
bnoordhuisaddaleax
authored andcommitted
build: make 'floating patch' message informational
Downgrade the 'Using floating patch' message that is emitted when a local patch is applied to the bundled ICU from a warning to a notice. There isn't anything the user can or should do so warning isn't appropriate. Instead of angry yellow use soothing green. Fixes: #26346 PR-URL: #26349 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
1 parent 8cf4170 commit 05e6ec0

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

configure.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -617,6 +617,10 @@ def warn(msg):
617617
# track if warnings occurred
618618
warn.warned = False
619619

620+
def info(msg):
621+
prefix = '\033[1m\033[32mINFO\033[0m' if os.isatty(1) else 'INFO'
622+
print('%s: %s' % (prefix, msg))
623+
620624
def print_verbose(x):
621625
if not options.verbose:
622626
return
@@ -1288,7 +1292,7 @@ def glob_to_var(dir_base, dir_sub, patch_dir):
12881292
patchfile = '%s/%s/%s' % (dir_base, patch_dir, file)
12891293
if os.path.isfile(patchfile):
12901294
srcfile = '%s/%s' % (patch_dir, file)
1291-
warn('Using floating patch "%s" from "%s"' % (patchfile, dir_base))
1295+
info('Using floating patch "%s" from "%s"' % (patchfile, dir_base))
12921296
list.append(srcfile)
12931297
break
12941298
return list

0 commit comments

Comments
 (0)