Skip to content

Commit 02e97fa

Browse files
Moisannoatamir
authored andcommitted
STYLE: fix pylint simplifiable-if-statement warnings (pandas-dev#49323)
* STYLE: fix pylint simplifiable-if-statement warnings * fixup! STYLE: fix pylint simplifiable-if-statement warnings
1 parent cfdfb6e commit 02e97fa

File tree

4 files changed

+5
-22
lines changed

4 files changed

+5
-22
lines changed

pandas/core/dtypes/dtypes.py

+2-8
Original file line numberDiff line numberDiff line change
@@ -986,10 +986,7 @@ def is_dtype(cls, dtype: object) -> bool:
986986
# but doesn't regard freq str like "U" as dtype.
987987
if dtype.startswith("period[") or dtype.startswith("Period["):
988988
try:
989-
if cls._parse_dtype_strict(dtype) is not None:
990-
return True
991-
else:
992-
return False
989+
return cls._parse_dtype_strict(dtype) is not None
993990
except ValueError:
994991
return False
995992
else:
@@ -1254,10 +1251,7 @@ def is_dtype(cls, dtype: object) -> bool:
12541251
if isinstance(dtype, str):
12551252
if dtype.lower().startswith("interval"):
12561253
try:
1257-
if cls.construct_from_string(dtype) is not None:
1258-
return True
1259-
else:
1260-
return False
1254+
return cls.construct_from_string(dtype) is not None
12611255
except (ValueError, TypeError):
12621256
return False
12631257
else:

pandas/io/formats/info.py

+2-8
Original file line numberDiff line numberDiff line change
@@ -500,10 +500,7 @@ def non_null_counts(self) -> Sequence[int]:
500500

501501
@property
502502
def memory_usage_bytes(self) -> int:
503-
if self.memory_usage == "deep":
504-
deep = True
505-
else:
506-
deep = False
503+
deep = self.memory_usage == "deep"
507504
return self.data.memory_usage(index=True, deep=deep).sum()
508505

509506
def render(
@@ -579,10 +576,7 @@ def memory_usage_bytes(self) -> int:
579576
memory_usage_bytes : int
580577
Object's total memory usage in bytes.
581578
"""
582-
if self.memory_usage == "deep":
583-
deep = True
584-
else:
585-
deep = False
579+
deep = self.memory_usage == "deep"
586580
return self.data.memory_usage(index=True, deep=deep)
587581

588582

pandas/tests/tseries/offsets/test_week.py

+1-5
Original file line numberDiff line numberDiff line change
@@ -114,11 +114,7 @@ def test_is_on_offset(self, weekday):
114114

115115
for day in range(1, 8):
116116
date = datetime(2008, 1, day)
117-
118-
if day % 7 == weekday:
119-
expected = True
120-
else:
121-
expected = False
117+
expected = day % 7 == weekday
122118
assert_is_on_offset(offset, date, expected)
123119

124120
@pytest.mark.parametrize(

pyproject.toml

-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ disable = [
125125
"no-self-use",
126126
"redefined-argument-from-local",
127127
"simplifiable-if-expression",
128-
"simplifiable-if-statement",
129128
"too-few-public-methods",
130129
"too-many-ancestors",
131130
"too-many-arguments",

0 commit comments

Comments
 (0)