Skip to content

Commit 87ebcbe

Browse files
Akos Kittakittaakos
Akos Kitta
authored andcommitted
Let CSS do the uppercase transformation.
Expose no implementation details to translation files. Signed-off-by: Akos Kitta <[email protected]>
1 parent 99b1094 commit 87ebcbe

File tree

5 files changed

+12
-13
lines changed

5 files changed

+12
-13
lines changed

arduino-ide-extension/src/browser/style/index.css

+3
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,9 @@ button.secondary[disabled], .theia-button.secondary[disabled] {
137137
font-size: 14px;
138138
}
139139

140+
.uppercase {
141+
text-transform: uppercase;
142+
}
140143

141144
/* High Contrast Theme rules */
142145
/* TODO: Remove it when the Theia version is upgraded to 1.27.0 and use Theia APIs to implement it*/

arduino-ide-extension/src/browser/style/list-widget.css

-2
Original file line numberDiff line numberDiff line change
@@ -112,14 +112,12 @@
112112
max-height: calc(1em + 4px);
113113
color: var(--theia-button-foreground);
114114
content: attr(install);
115-
text-transform: uppercase;
116115
}
117116

118117
.component-list-item .header .installed:hover:before {
119118
background-color: var(--theia-button-foreground);
120119
color: var(--theia-button-background);
121120
content: attr(uninstall);
122-
text-transform: uppercase;
123121
}
124122

125123
.component-list-item[min-width~="170px"] .footer {

arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-tree-widget.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,10 @@ export class CloudSketchbookTreeWidget extends SketchbookTreeWidget {
6161
</div>
6262
</div>
6363
<button
64-
className="theia-button"
64+
className="theia-button uppercase"
6565
onClick={() => shell.openExternal('https://create.arduino.cc/editor')}
6666
>
67-
{nls.localize('cloud/GoToCloud', 'GO TO CLOUD')}
67+
{nls.localize('arduino/cloud/goToCloud', 'Go to Cloud')}
6868
</button>
6969
<div className="center item"></div>
7070
</div>

arduino-ide-extension/src/browser/widgets/component-list/list-item-renderer.tsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ export class ListItemRenderer<T extends ArduinoComponent> {
5656
)}
5757
</span>
5858
<span
59-
className="installed"
59+
className="installed uppercase"
6060
onClick={onClickUninstall}
6161
{...{
62-
install: nls.localize('arduino/component/installed', 'INSTALLED'),
62+
install: nls.localize('arduino/component/installed', 'Installed'),
6363
uninstall: nls.localize('arduino/component/uninstall', 'Uninstall'),
6464
}}
6565
/>
@@ -77,10 +77,10 @@ export class ListItemRenderer<T extends ArduinoComponent> {
7777
const onClickInstall = () => install(item);
7878
const installButton = item.installable && (
7979
<button
80-
className="theia-button secondary install"
80+
className="theia-button secondary install uppercase"
8181
onClick={onClickInstall}
8282
>
83-
{nls.localize('arduino/component/install', 'INSTALL')}
83+
{nls.localize('arduino/component/install', 'Install')}
8484
</button>
8585
);
8686

i18n/en.json

+3-5
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@
9090
"donePushing": "Done pushing ‘{0}’.",
9191
"embed": "Embed:",
9292
"emptySketchbook": "Your Sketchbook is empty",
93+
"goToCloud": "Go to Cloud",
9394
"learnMore": "Learn more",
9495
"link": "Link:",
9596
"notYetPulled": "Cannot push to Cloud. It is not yet pulled.",
@@ -144,8 +145,8 @@
144145
"boardsIncluded": "Boards included in this package:",
145146
"by": "by",
146147
"filterSearch": "Filter your search...",
147-
"install": "INSTALL",
148-
"installed": "INSTALLED",
148+
"install": "Install",
149+
"installed": "Installed",
149150
"moreInfo": "More info",
150151
"uninstall": "Uninstall",
151152
"uninstallMsg": "Do you want to uninstall {0}?",
@@ -422,9 +423,6 @@
422423
"upload": "Upload"
423424
}
424425
},
425-
"cloud": {
426-
"GoToCloud": "GO TO CLOUD"
427-
},
428426
"theia": {
429427
"core": {
430428
"cannotConnectBackend": "Cannot connect to the backend.",

0 commit comments

Comments
 (0)