feature: add p2 deprecation for PT>=1.13 (aws#3567)

* feat: (squash and push to use git hooks) add p2 deprecation for retrieving pytorch img uri

style: format _validate_instance_deprecation using black

doc: add docstring for _validate_instance_deprecation

doc: update deprecation error string

doc: update docstring for _validate_instance_deprecation

* fix: use Version packaging to compare version

* test: add E1136 to pylintrc disable list

Co-authored-by: Shibo Xing <[email protected]>

Author: 2 people

.pylintrc

@@ -94,6 +94,7 @@ disable=
     useless-object-inheritance, # TODO: Enable this check and fix code once Python 2 is no longer supported.
     super-with-arguments,
     raise-missing-from,
+    E1136,
 
 [REPORTS]
 # Set the output format. Available formats are text, parseable, colorized, msvs

src/sagemaker/image_uris.py

@@ -18,6 +18,7 @@
 import os
 import re
 from typing import Optional
+from packaging.version import Version
 
 from sagemaker import utils
 from sagemaker.jumpstart.utils import is_jumpstart_model_input
@@ -232,6 +233,7 @@ def retrieve(
 
     if repo == f"{framework}-inference-graviton":
         container_version = f"{container_version}-sagemaker"
+    _validate_instance_deprecation(framework, instance_type, version)
 
     tag = _get_image_tag(
         container_version,
@@ -365,6 +367,20 @@ def _config_for_framework_and_scope(framework, image_scope, accelerator_type=Non
     return config if "scope" in config else config[image_scope]
 
 
+def _validate_instance_deprecation(framework, instance_type, version):
+    """Check if instance type is deprecated for a certain framework with a certain version"""
+    if (
+        framework == "pytorch"
+        and _get_instance_type_family(instance_type) == "p2"
+        and Version(version) >= Version("1.13")
+    ):
+        raise ValueError(
+            "P2 instances have been deprecated for sagemaker jobs with PyTorch 1.13 and above. "
+            "For information about supported instance types please refer to "
+            "https://aws.amazon.com/sagemaker/pricing/"
+        )
+
+
 def _validate_for_suppported_frameworks_and_instance_type(framework, instace_type):
     """Validate if framework is supported for the instance_type"""
     if (