Skip to content

Commit d7f7df1

Browse files
author
Nishanth Shanmugham
committed
assign a=false, not all=false (same effect but more appropriate)
1 parent ce99d58 commit d7f7df1

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

common_go118.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ func fromInterface(pass *analysis.Pass, intf *types.Interface, typeparam bool) (
6262
r, a := fromType(pass, u.Term(i).Type(), typeparam)
6363
for _, rr := range r {
6464
if !sameBasicKind(rr.et.TypeName.Type()) {
65-
all = false
65+
a = false
6666
break
6767
}
6868
}
@@ -74,7 +74,7 @@ func fromInterface(pass *analysis.Pass, intf *types.Interface, typeparam bool) (
7474
r, a := fromNamed(pass, embed.(*types.Named), typeparam)
7575
for _, rr := range r {
7676
if !sameBasicKind(rr.et.TypeName.Type()) {
77-
all = false
77+
a = false
7878
break
7979
}
8080
}

exhaustive.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ The Go [language spec] does not provide an explicit definition for enums. For
1010
the purpose of this analyzer, and by convention, an enum type is any named
1111
type that:
1212
13-
1. has underlying type float, string, or integer (includes byte and
13+
- has underlying type float, string, or integer (includes byte and
1414
rune, which are aliases for uint8 and int32, respectively); and
15-
2. has at least one constant of the type defined in the same scope.
15+
- has at least one constant of the type defined in the same scope.
1616
17-
In the example below, Biome is an enum type. The 3 constants are its
17+
In the example below, Biome is an enum type. The three constants are its
1818
enum members.
1919
2020
package eco

0 commit comments

Comments
 (0)