Skip to content

Commit 0caf3e2

Browse files
committed
Merge branch 'master' into thefill/master-2
# Conflicts: # packages/react-scripts/package.json
2 parents cd704af + 2cb3de9 commit 0caf3e2

File tree

255 files changed

+161
-96195
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

255 files changed

+161
-96195
lines changed

.travis.yml

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2,27 +2,10 @@
22
dist: trusty
33
language: node_js
44
node_js:
5-
- 8
65
- 9
76
cache:
87
directories:
98
- node_modules
10-
- packages/create-react-app/node_modules
11-
- packages/react-scripts/node_modules
129
install: true
1310
script:
14-
- 'if [ $TEST_SUITE = "simple" ]; then tasks/e2e-simple.sh; fi'
15-
- 'if [ $TEST_SUITE = "kitchensink" ]; then tasks/e2e-kitchensink.sh; fi'
16-
- 'if [ $TEST_SUITE = "old-node" ]; then tasks/e2e-old-node.sh; fi'
17-
# Disabled for the moment, since it requires additional work to be done.
18-
# - 'if [ $TEST_SUITE = "installs" ]; then tasks/e2e-installs.sh; fi'
19-
env:
20-
matrix:
21-
- TEST_SUITE=simple
22-
- TEST_SUITE=kitchensink
23-
# See comment above
24-
# - TEST_SUITE=installs
25-
matrix:
26-
include:
27-
- node_js: 6
28-
env: TEST_SUITE=kitchensink
11+
- 'tasks/e2e-simple.sh'

CHANGELOG-0.x.md

Lines changed: 0 additions & 1374 deletions
This file was deleted.

CHANGELOG.md

Whitespace-only changes.

CODE_OF_CONDUCT.md

Lines changed: 0 additions & 3 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 0 additions & 132 deletions
This file was deleted.

LICENSE

Lines changed: 0 additions & 21 deletions
This file was deleted.

README.md

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,27 +3,35 @@
33
Create React apps (with Typescript) with no build configuration.
44

55
* [Getting Started](#tldr) – How to create a new app.
6-
* [User Guide](https://github.com/wmonk/create-react-app-typescript/blob/master/packages/react-scripts/template/README.md) – How to develop apps bootstrapped with react scripts ts.
6+
* [User Guide](https://github.com/wmonk/create-react-app-typescript/blob/master/template/README.md) – How to develop apps bootstrapped with react scripts ts.
77

88
_Do you know react and want to try out typescript? Or do you know typescript and want to try out react?_ Get all the benefits from `create-react-app` but you use typescript! 🚀
99

10-
## tl;dr
10+
## Quick Overview
1111

1212
```sh
13-
npm install -g create-react-app
14-
15-
create-react-app my-app --scripts-version=react-scripts-ts
16-
cd my-app/
13+
npx create-react-app my-app --scripts-version=react-scripts-ts
14+
cd my-app
1715
npm start
16+
17+
# or with yarn
18+
yarn create react-app my-app --scripts-version=react-scripts-ts
19+
cd my-app
20+
yarn start
1821
```
1922

23+
*([npx](https://medium.com/@maybekatz/introducing-npx-an-npm-package-runner-55f7d4bd282b) comes with npm 5.2+ and higher, see [instructions for older npm versions](https://gist.github.com/gaearon/4064d3c23a77c74a3614c498a8bb1c5f))*
24+
25+
Then open [http://localhost:3000/](http://localhost:3000/) to see your app.<br>
26+
When you’re ready to deploy to production, create a minified bundle with `npm run build`.
27+
2028
## Migration
2129

2230
In general, most upgrades won't require any migration steps to work, but if you experience problems after an upgrade, please file an issue, and we'll add it to the list of migration steps below.
2331

2432
### From `<2.16.0` to `>=2.16.0`
2533

26-
Since `2.16.0`, the template uses different `tsconfig` files for both development and production mode. For the latter, unfortunately, the path resolver is not smart enough to fall back to the basic `tsconfig.json` in case the expected `tsconfig.prod.json` is not present, so you have to create this file manually like shown [here](https://github.com/wmonk/create-react-app-typescript/blob/master/packages/react-scripts/template/tsconfig.prod.json).
34+
Since `2.16.0`, the template uses different `tsconfig` files for both development and production mode. For the latter, unfortunately, the path resolver is not smart enough to fall back to the basic `tsconfig.json` in case the expected `tsconfig.prod.json` is not present, so you have to create this file manually like shown [here](https://github.com/wmonk/create-react-app-typescript/blob/master/template/tsconfig.prod.json).
2735

2836
### From `<2.13.0` to `>=2.13.0`
2937

@@ -53,10 +61,16 @@ Test suite failed to run
5361
}
5462
```
5563

56-
To fix this, create a new file *in the root of the project* called `tsconfig.test.json`, and paste [the content of this file into it](https://raw.githubusercontent.com/wmonk/create-react-app-typescript/master/packages/react-scripts/template/tsconfig.test.json). Everything should work now. For more info, please see [this issue](https://github.com/wmonk/create-react-app-typescript/issues/141).
64+
To fix this, create a new file *in the root of the project* called `tsconfig.test.json`, and paste [the content of this file into it](https://raw.githubusercontent.com/wmonk/create-react-app-typescript/master/template/tsconfig.test.json). Everything should work now. For more info, please see [this issue](https://github.com/wmonk/create-react-app-typescript/issues/141).
5765

5866
## Changelog
5967

68+
### 2.17.0
69+
* Update migration instructions - @DorianGrey
70+
* tslint updates - @alexandrudanpop
71+
* Stop eslint includes - @aurerua
72+
* Resolve commited merge conflig - @AndrewKvalheim
73+
6074
### 2.16.0
6175
* Allow `moduleNameMapper` config override - @sebald
6276
* Fix travis build - @DorianGrey

appveyor.cleanup-cache.txt

Lines changed: 0 additions & 6 deletions
This file was deleted.

appveyor.yml

Lines changed: 0 additions & 42 deletions
This file was deleted.

bootstrap.js

Lines changed: 0 additions & 67 deletions
This file was deleted.
File renamed without changes.
File renamed without changes.
File renamed without changes.

packages/react-scripts/config/webpack.config.prod.js renamed to config/webpack.config.prod.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,9 @@ module.exports = {
353353
// Pending further investigation:
354354
// https://github.com/mishoo/UglifyJS2/issues/2011
355355
comparisons: false,
356+
// Don't inline functions with arguments, to avoid name collisions:
357+
// https://github.com/mishoo/UglifyJS2/issues/2842
358+
inline: 1,
356359
},
357360
mangle: {
358361
safari10: true,
File renamed without changes.

0 commit comments

Comments
 (0)