[DebugInfo] Fix pessimizing move. NFC.

d0k · d0k · commit d36b8414bdde · 2020-07-09T14:23:46.000+02:00
DWARFDebugPubTable.cpp:80:31: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
diff --git a/llvm/lib/DebugInfo/DWARF/DWARFDebugPubTable.cpp b/llvm/lib/DebugInfo/DWARF/DWARFDebugPubTable.cpp
@@ -77,7 +77,7 @@ void DWARFDebugPubTable::extract(
       RecoverableErrorHandler(createStringError(
           errc::invalid_argument,
           "name lookup table at offset 0x%" PRIx64 " parsing failed: %s",
-          SetOffset, toString(std::move(C.takeError())).c_str()));
+          SetOffset, toString(C.takeError()).c_str()));
       continue;
     }
     if (C.tell() != Offset)

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ void DWARFDebugPubTable::extract(`
`77`	`77`	`RecoverableErrorHandler(createStringError(`
`78`	`78`	`errc::invalid_argument,`
`79`	`79`	`"name lookup table at offset 0x%" PRIx64 " parsing failed: %s",`
`80`		`- SetOffset, toString(std::move(C.takeError())).c_str()));`
	`80`	`+ SetOffset, toString(C.takeError()).c_str()));`
`81`	`81`	`continue;`
`82`	`82`	`}`
`83`	`83`	`if (C.tell() != Offset)`