[ELF] Simplify includeInDynsym for --dynamic-list

MaskRay · MaskRay · commit d31fb264821c · 2024-12-07T22:57:25.000-08:00
diff --git a/lld/ELF/SymbolTable.cpp b/lld/ELF/SymbolTable.cpp
@@ -203,7 +203,7 @@ void SymbolTable::handleDynamicList() {
       syms = findByVersion(ver);
 
     for (Symbol *sym : syms)
-      sym->inDynamicList = true;
+      sym->exportDynamic = sym->inDynamicList = true;
   }
 }
 
diff --git a/lld/ELF/Symbols.cpp b/lld/ELF/Symbols.cpp
@@ -278,7 +278,7 @@ bool Symbol::includeInDynsym(Ctx &ctx) const {
     // __pthread_initialize_minimal reference in csu/libc-start.c.
     return !(isUndefWeak() && ctx.arg.noDynamicLinker);
 
-  return exportDynamic || inDynamicList;
+  return exportDynamic;
 }
 
 // Print out a log message for --trace-symbol.

Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,7 @@ void SymbolTable::handleDynamicList() {`
`203`	`203`	`syms = findByVersion(ver);`
`204`	`204`
`205`	`205`	`for (Symbol *sym : syms)`
`206`		`- sym->inDynamicList = true;`
	`206`	`+ sym->exportDynamic = sym->inDynamicList = true;`
`207`	`207`	`}`
`208`	`208`	`}`
`209`	`209`
Original file line number	Diff line number	Diff line change
`@@ -278,7 +278,7 @@ bool Symbol::includeInDynsym(Ctx &ctx) const {`
`278`	`278`	`// __pthread_initialize_minimal reference in csu/libc-start.c.`
`279`	`279`	`return !(isUndefWeak() && ctx.arg.noDynamicLinker);`
`280`	`280`
`281`		`- return exportDynamic \|\| inDynamicList;`
	`281`	`+ return exportDynamic;`
`282`	`282`	`}`
`283`	`283`
`284`	`284`	`// Print out a log message for --trace-symbol.`