[libc] Add a convenience CMake rule to add testsuites.

Siva Chandra Reddy · Siva Chandra Reddy · commit 880734aebb39 · 2020-01-07T23:04:52.000-08:00
Summary: This rule helps avoid repeated setting of check-libc's dependency on the various testsuites. Reviewers: abrachet Subscribers: mgorny, MaskRay, tschuett, libc-commits Tags: #libc-project Differential Revision: https://reviews.llvm.org/D72353
diff --git a/libc/cmake/modules/LLVMLibCRules.cmake b/libc/cmake/modules/LLVMLibCRules.cmake
@@ -371,3 +371,8 @@ function(add_libc_unittest target_name)
     )
   endif()
 endfunction(add_libc_unittest)
+
+function(add_libc_testsuite suite_name)
+  add_custom_target(${suite_name})
+  add_dependencies(check-libc ${suite_name})
+endfunction(add_libc_testsuite)
diff --git a/libc/test/CMakeLists.txt b/libc/test/CMakeLists.txt
@@ -1,4 +1,4 @@
-add_custom_target(check_libc)
+add_custom_target(check-libc)
 
 add_subdirectory(config)
 add_subdirectory(src)
diff --git a/libc/test/config/CMakeLists.txt b/libc/test/config/CMakeLists.txt
@@ -1 +1 @@
-add_subdirectory(linux)
+add_subdirectory(${LIBC_TARGET_OS})
diff --git a/libc/test/config/linux/CMakeLists.txt b/libc/test/config/linux/CMakeLists.txt
@@ -1,4 +1,3 @@
-add_custom_target(libc_linux_tests)
-add_dependencies(check_libc libc_linux_tests)
+add_libc_testsuite(libc_linux_tests)
 
-add_subdirectory(x86_64)
+add_subdirectory(${LIBC_TARGET_MACHINE})
diff --git a/libc/test/config/linux/x86_64/CMakeLists.txt b/libc/test/config/linux/x86_64/CMakeLists.txt
@@ -1,9 +1,6 @@
-add_custom_target(libc_linux_x86_64_tests)
-add_dependencies(libc_linux_tests libc_linux_x86_64_tests)
-
 add_libc_unittest(
   libc_linux_x86_64_syscall_unittest
-  SUITE libc_linux_x86_64_tests
+  SUITE libc_linux_tests
   SRCS syscall_test.cpp
   DEPENDS
    syscall_impl_h
diff --git a/libc/test/src/errno/CMakeLists.txt b/libc/test/src/errno/CMakeLists.txt
@@ -1,5 +1,4 @@
-add_custom_target(libc_errno_unittests)
-add_dependencies(check_libc libc_errno_unittests)
+add_libc_testsuite(libc_errno_unittests)
 
 add_libc_unittest(
   errno_test
diff --git a/libc/test/src/string/CMakeLists.txt b/libc/test/src/string/CMakeLists.txt
@@ -1,5 +1,4 @@
-add_custom_target(libc_string_unittests)
-add_dependencies(check_libc libc_string_unittests)
+add_libc_testsuite(libc_string_unittests)
 
 add_libc_unittest(
   strcat_test
diff --git a/libc/test/src/sys/mman/CMakeLists.txt b/libc/test/src/sys/mman/CMakeLists.txt
@@ -1,5 +1,4 @@
-add_custom_target(libc_sys_mman_unittests)
-add_dependencies(check_libc libc_sys_mman_unittests)
+add_libc_testsuite(libc_sys_mman_unittests)
 
 add_libc_unittest(
   mmap_test

Original file line number	Diff line number	Diff line change
`@@ -371,3 +371,8 @@ function(add_libc_unittest target_name)`
`371`	`371`	`)`
`372`	`372`	`endif()`
`373`	`373`	`endfunction(add_libc_unittest)`
	`374`	`+`
	`375`	`+function(add_libc_testsuite suite_name)`
	`376`	`+ add_custom_target(${suite_name})`
	`377`	`+ add_dependencies(check-libc ${suite_name})`
	`378`	`+endfunction(add_libc_testsuite)`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-add_subdirectory(linux)`
	`1`	`+add_subdirectory(${LIBC_TARGET_OS})`