Skip to content

Commit 8291147

Browse files
authored
[mlir][SCF] Minor fixes in documentation examples (llvm#69802)
scf.forall.parallel_insert_slice -> tensor.parallel_insert_slice add -> linalg.add map -> linalg.map matmul -> linalg.matmul
1 parent 3651f37 commit 8291147

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

mlir/include/mlir/Dialect/SCF/IR/SCFOps.td

+10-6
Original file line numberDiff line numberDiff line change
@@ -411,17 +411,19 @@ def ForallOp : SCF_Op<"forall", [
411411
tensor<?x?xT> to tensor<?x?xT>
412412
%sC = tensor.extract_slice %o1[h((%thread_id_1, %thread_id_2))]:
413413
tensor<?x?xT> to tensor<?x?xT>
414-
%sD = matmul ins(%sA, %sB) outs(%sC)
414+
%sD = linalg.matmul
415+
ins(%sA, %sB : tensor<?x?xT>, tensor<?x?xT>)
416+
outs(%sC : tensor<?x?xT>)
415417

416418
%spointwise = subtensor %o2[i((%thread_id_1, %thread_id_2))]:
417419
tensor<?xT> to tensor<?xT>
418-
%sE = add ins(%spointwise) outs(%sD)
420+
%sE = linalg.add ins(%spointwise : tensor<?xT>) outs(%sD : tensor<?xT>)
419421

420422
scf.forall.in_parallel {
421-
scf.forall.parallel_insert_slice %sD into %o1[h((%thread_id_1, %thread_id_2))]:
423+
tensor.parallel_insert_slice %sD into %o1[h((%thread_id_1, %thread_id_2))]:
422424
tensor<?x?xT> into tensor<?x?xT>
423425

424-
scf.forall.parallel_insert_slice %spointwise into %o2[i((%thread_id_1, %thread_id_2))]:
426+
tensor.parallel_insert_slice %spointwise into %o2[i((%thread_id_1, %thread_id_2))]:
425427
tensor<?xT> into tensor<?xT>
426428
}
427429
}
@@ -449,10 +451,12 @@ def ForallOp : SCF_Op<"forall", [
449451
%sC = tensor.extract_slice %o[%i, %j][%tileSize1, %tileSize2][1, 1]
450452
: tensor<?x?xT> to tensor<?x?xT>
451453

452-
%add = map {"arith.addf"} ins(%sA, %sB) outs(%sC)
454+
%add = linalg.map {"arith.addf"}
455+
ins(%sA, %sB : tensor<?x?xT>, tensor<?x?xT>)
456+
outs(%sC : tensor<?x?xT>)
453457

454458
scf.forall.in_parallel {
455-
scf.forall.parallel_insert_slice %add into
459+
tensor.parallel_insert_slice %add into
456460
%o[%i, %j][%tileSize1, %tileSize2][1, 1]
457461
: tensor<?x?xT> into tensor<?x?xT>
458462
}

0 commit comments

Comments
 (0)