Skip to content

Commit 564b9b7

Browse files
authored
Revert "CodeGen][NewPM] Port MachineScheduler to NPM. (llvm#125703)" (llvm#126268)
This reverts commit 5aa4979 while I investigate what's causing the compile-time regression.
1 parent 027aa70 commit 564b9b7

File tree

56 files changed

+95
-366
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+95
-366
lines changed

llvm/include/llvm/CodeGen/MachineScheduler.h

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1385,24 +1385,6 @@ std::unique_ptr<ScheduleDAGMutation>
13851385
createCopyConstrainDAGMutation(const TargetInstrInfo *TII,
13861386
const TargetRegisterInfo *TRI);
13871387

1388-
class MachineSchedulerPass : public PassInfoMixin<MachineSchedulerPass> {
1389-
const TargetMachine *TM;
1390-
1391-
public:
1392-
MachineSchedulerPass(const TargetMachine *TM) : TM(TM) {}
1393-
PreservedAnalyses run(MachineFunction &MF,
1394-
MachineFunctionAnalysisManager &MFAM);
1395-
};
1396-
1397-
class PostMachineSchedulerPass
1398-
: public PassInfoMixin<PostMachineSchedulerPass> {
1399-
const TargetMachine *TM;
1400-
1401-
public:
1402-
PostMachineSchedulerPass(const TargetMachine *TM) : TM(TM) {}
1403-
PreservedAnalyses run(MachineFunction &MF,
1404-
MachineFunctionAnalysisManager &MFAM);
1405-
};
14061388
} // end namespace llvm
14071389

14081390
#endif // LLVM_CODEGEN_MACHINESCHEDULER_H

llvm/include/llvm/InitializePasses.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ void initializeMachinePipelinerPass(PassRegistry &);
209209
void initializeMachinePostDominatorTreeWrapperPassPass(PassRegistry &);
210210
void initializeMachineRegionInfoPassPass(PassRegistry &);
211211
void initializeMachineSanitizerBinaryMetadataPass(PassRegistry &);
212-
void initializeMachineSchedulerLegacyPass(PassRegistry &);
212+
void initializeMachineSchedulerPass(PassRegistry &);
213213
void initializeMachineSinkingPass(PassRegistry &);
214214
void initializeMachineTraceMetricsWrapperPassPass(PassRegistry &);
215215
void initializeMachineUniformityInfoPrinterPassPass(PassRegistry &);
@@ -238,7 +238,7 @@ void initializePostDomPrinterWrapperPassPass(PassRegistry &);
238238
void initializePostDomViewerWrapperPassPass(PassRegistry &);
239239
void initializePostDominatorTreeWrapperPassPass(PassRegistry &);
240240
void initializePostInlineEntryExitInstrumenterPass(PassRegistry &);
241-
void initializePostMachineSchedulerLegacyPass(PassRegistry &);
241+
void initializePostMachineSchedulerPass(PassRegistry &);
242242
void initializePostRAHazardRecognizerPass(PassRegistry &);
243243
void initializePostRAMachineSinkingPass(PassRegistry &);
244244
void initializePostRASchedulerLegacyPass(PassRegistry &);

llvm/include/llvm/Passes/CodeGenPassBuilder.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
#include "llvm/CodeGen/MachineLICM.h"
5151
#include "llvm/CodeGen/MachineModuleInfo.h"
5252
#include "llvm/CodeGen/MachinePassManager.h"
53-
#include "llvm/CodeGen/MachineScheduler.h"
5453
#include "llvm/CodeGen/MachineVerifier.h"
5554
#include "llvm/CodeGen/OptimizePHIs.h"
5655
#include "llvm/CodeGen/PHIElimination.h"
@@ -961,7 +960,7 @@ Error CodeGenPassBuilder<Derived, TargetMachineT>::addMachinePasses(
961960
if (getOptLevel() != CodeGenOptLevel::None &&
962961
!TM.targetSchedulesPostRAScheduling()) {
963962
if (Opt.MISchedPostRA)
964-
addPass(PostMachineSchedulerPass(&TM));
963+
addPass(PostMachineSchedulerPass());
965964
else
966965
addPass(PostRASchedulerPass(&TM));
967966
}
@@ -1145,7 +1144,7 @@ void CodeGenPassBuilder<Derived, TargetMachineT>::addOptimizedRegAlloc(
11451144
addPass(RenameIndependentSubregsPass());
11461145

11471146
// PreRA instruction scheduling.
1148-
addPass(MachineSchedulerPass(&TM));
1147+
addPass(MachineSchedulerPass());
11491148

11501149
if (derived().addRegAssignmentOptimized(addPass)) {
11511150
// Allow targets to expand pseudo instructions depending on the choice of

llvm/include/llvm/Passes/MachinePassRegistry.def

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,13 +142,11 @@ MACHINE_FUNCTION_PASS("finalize-isel", FinalizeISelPass())
142142
MACHINE_FUNCTION_PASS("localstackalloc", LocalStackSlotAllocationPass())
143143
MACHINE_FUNCTION_PASS("machine-cp", MachineCopyPropagationPass())
144144
MACHINE_FUNCTION_PASS("machine-cse", MachineCSEPass())
145-
MACHINE_FUNCTION_PASS("machine-scheduler", MachineSchedulerPass(TM))
146145
MACHINE_FUNCTION_PASS("machinelicm", MachineLICMPass())
147146
MACHINE_FUNCTION_PASS("no-op-machine-function", NoOpMachineFunctionPass())
148147
MACHINE_FUNCTION_PASS("opt-phis", OptimizePHIsPass())
149148
MACHINE_FUNCTION_PASS("peephole-opt", PeepholeOptimizerPass())
150149
MACHINE_FUNCTION_PASS("phi-node-elimination", PHIEliminationPass())
151-
MACHINE_FUNCTION_PASS("postmisched", PostMachineSchedulerPass(TM))
152150
MACHINE_FUNCTION_PASS("post-RA-sched", PostRASchedulerPass(TM))
153151
MACHINE_FUNCTION_PASS("print", PrintMIRPass())
154152
MACHINE_FUNCTION_PASS("print<livedebugvars>", LiveDebugVariablesPrinterPass(errs()))
@@ -245,11 +243,13 @@ DUMMY_MACHINE_FUNCTION_PASS("static-data-splitter", StaticDataSplitter)
245243
DUMMY_MACHINE_FUNCTION_PASS("machine-function-splitter", MachineFunctionSplitterPass)
246244
DUMMY_MACHINE_FUNCTION_PASS("machine-latecleanup", MachineLateInstrsCleanupPass)
247245
DUMMY_MACHINE_FUNCTION_PASS("machine-sanmd", MachineSanitizerBinaryMetadata)
246+
DUMMY_MACHINE_FUNCTION_PASS("machine-scheduler", MachineSchedulerPass)
248247
DUMMY_MACHINE_FUNCTION_PASS("machine-sink", MachineSinkingPass)
249248
DUMMY_MACHINE_FUNCTION_PASS("machine-uniformity", MachineUniformityInfoWrapperPass)
250249
DUMMY_MACHINE_FUNCTION_PASS("machineinstr-printer", MachineFunctionPrinterPass)
251250
DUMMY_MACHINE_FUNCTION_PASS("mirfs-discriminators", MIRAddFSDiscriminatorsPass)
252251
DUMMY_MACHINE_FUNCTION_PASS("patchable-function", PatchableFunctionPass)
252+
DUMMY_MACHINE_FUNCTION_PASS("postmisched", PostMachineSchedulerPass)
253253
DUMMY_MACHINE_FUNCTION_PASS("postra-machine-sink", PostRAMachineSinkingPass)
254254
DUMMY_MACHINE_FUNCTION_PASS("postrapseudos", ExpandPostRAPseudosPass)
255255
DUMMY_MACHINE_FUNCTION_PASS("print-machine-cycles", MachineCycleInfoPrinterPass)

llvm/lib/CodeGen/CodeGen.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ void llvm::initializeCodeGen(PassRegistry &Registry) {
9494
initializeModuloScheduleTestPass(Registry);
9595
initializeMachinePostDominatorTreeWrapperPassPass(Registry);
9696
initializeMachineRegionInfoPassPass(Registry);
97-
initializeMachineSchedulerLegacyPass(Registry);
97+
initializeMachineSchedulerPass(Registry);
9898
initializeMachineSinkingPass(Registry);
9999
initializeMachineUniformityAnalysisPassPass(Registry);
100100
initializeMachineUniformityInfoPrinterPassPass(Registry);
@@ -105,7 +105,7 @@ void llvm::initializeCodeGen(PassRegistry &Registry) {
105105
initializePHIEliminationPass(Registry);
106106
initializePatchableFunctionPass(Registry);
107107
initializePeepholeOptimizerLegacyPass(Registry);
108-
initializePostMachineSchedulerLegacyPass(Registry);
108+
initializePostMachineSchedulerPass(Registry);
109109
initializePostRAHazardRecognizerPass(Registry);
110110
initializePostRAMachineSinkingPass(Registry);
111111
initializePostRASchedulerLegacyPass(Registry);

0 commit comments

Comments
 (0)