Skip to content

Commit 2dd6b91

Browse files
plotfizmodem
authored andcommitted
[clang][IFS][test] Temporary work around for in-process cc1 ASAN issues.
When using in-process cc1, the Clang Interface Stubs pipeline setup exposes an ASAN bug. I am still investigating this issue but want to green the bots for now. I don't think this is a huge issue since the Clang Interface Stubs Driver setup code is the only code path that sets up such a pipeline (ie N cc1's for N c files followed by another N cc1's for to generate stub files for the same N c files). This issue is being discussed in https://reviews.llvm.org/D69825. If a resolution is not found soon, a bugzilla filling will be in order. (cherry picked from commit c38e425)
1 parent 26fd69a commit 2dd6b91

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

clang/test/InterfaceStubs/driver-test.c

+10-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,17 @@
11
// REQUIRES: x86-registered-target
22
// REQUIRES: shell
33

4+
// NOTE: -fno-integrated-cc1 has been added to work around an ASAN failure
5+
// caused by in-process cc1 invocation. Clang InterfaceStubs is not the
6+
// culprit, but Clang Interface Stubs' Driver pipeline setup uncovers an
7+
// existing ASAN issue when invoking multiple normal cc1 jobs along with
8+
// multiple Clang Interface Stubs cc1 jobs together.
9+
// There is currently a discussion of this going on at:
10+
// https://reviews.llvm.org/D69825
411
// RUN: mkdir -p %t; cd %t
5-
// RUN: %clang -target x86_64-unknown-linux-gnu -x c -S -emit-interface-stubs %s %S/object.c %S/weak.cpp && \
12+
// RUN: %clang -target x86_64-unknown-linux-gnu -x c -S \
13+
// RUN: -fno-integrated-cc1 \
14+
// RUN: -emit-interface-stubs %s %S/object.c %S/weak.cpp && \
615
// RUN: llvm-nm %t/a.out.ifso 2>&1 | FileCheck --check-prefix=CHECK-IFS %s
716

817
// CHECK-IFS-DAG: data

clang/test/InterfaceStubs/driver-test2.c

+9
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,19 @@
11
// REQUIRES: x86-registered-target
22
// REQUIRES: shell
33

4+
// NOTE: -fno-integrated-cc1 has been added to work around an ASAN failure
5+
// caused by in-process cc1 invocation. Clang InterfaceStubs is not the
6+
// culprit, but Clang Interface Stubs' Driver pipeline setup uncovers an
7+
// existing ASAN issue when invoking multiple normal cc1 jobs along with
8+
// multiple Clang Interface Stubs cc1 jobs together.
9+
// There is currently a discussion of this going on at:
10+
// https://reviews.llvm.org/D69825
411
// RUN: mkdir -p %t; cd %t
512
// RUN: %clang -target x86_64-unknown-linux-gnu -c -emit-interface-stubs \
13+
// RUN: -fno-integrated-cc1 \
614
// RUN: %s %S/object.c %S/weak.cpp
715
// RUN: %clang -emit-interface-stubs -emit-merged-ifs \
16+
// RUN: -fno-integrated-cc1 \
817
// RUN: %t/driver-test2.o %t/object.o %t/weak.o -S -o - 2>&1 | FileCheck %s
918

1019
// CHECK-DAG: data

0 commit comments

Comments
 (0)