Skip to content

Commit 3b565b4

Browse files
authored
fix(data): remove strict typing for optimistic false (#3020)
Additional overload for `.add()` on NgRx Data Service causes issue when passing in `boolean` to `isOptimistic`. Remove overload as it should not be needed. Resolves #2928
1 parent 045c4c3 commit 3b565b4

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

modules/data/src/entity-services/entity-collection-service-base.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,6 @@ export class EntityCollectionServiceBase<
145145
entity: Partial<T>,
146146
options: EntityActionOptions & { isOptimistic: false }
147147
): Observable<T>;
148-
add(
149-
entity: T,
150-
options?: EntityActionOptions & { isOptimistic?: true }
151-
): Observable<T>;
152148
add(entity: T, options?: EntityActionOptions): Observable<T> {
153149
return this.dispatcher.add(entity, options);
154150
}

0 commit comments

Comments
 (0)