Error strings should not be capitalized

Author: lucacome

cmd/agent/main.go

@@ -21,12 +21,12 @@ func main() {
 
 	globalConfig, err := agent.ParseConfig(configFile)
 	if err != nil {
-		log.Fatalf("Error generating the config: %v", err)
+		log.Fatalf("error generating the config: %v", err)
 	}
 
 	a, err := agent.New(globalConfig)
 	if err != nil {
-		log.Fatalf("Error creating the agent: %v", err)
+		log.Fatalf("error creating the agent: %v", err)
 	}
 
 	go handleTermination()

internal/agent/agent.go

@@ -66,7 +66,7 @@ func (agent *Agent) configure() error {
 	agent.namedServices = make(map[string]string)
 	for _, svc := range agent.services.Feeds {
 		if _, ok := feedNames[svc.FeedName]; !ok {
-			return fmt.Errorf("Feed Name %v not found in NS1 DataFeed with source = %v. Review NS1 configuration", svc.FeedName, agent.pusher.Cfg.SourceID)
+			return fmt.Errorf("feed Name %v not found in NS1 DataFeed with source = %v. Review NS1 configuration", svc.FeedName, agent.pusher.Cfg.SourceID)
 		}
 		if agent.services.Method == globalMethod {
 			agent.namedServices[svc.FeedName] = svc.FeedName
@@ -97,7 +97,7 @@ func (agent *Agent) processData(statsSlice []*client.Stats) (map[string]*interna
 			}
 
 			if feedData == nil {
-				log.Printf("Error: [%v] source was not found in the remote NGINX Plus instance(s). Check NGINX Plus config file or agent config file.", src)
+				log.Printf("error: [%v] source was not found in the remote NGINX Plus instance(s). Check NGINX Plus config file or agent config file.", src)
 				continue
 			}
 			newData[feed] = feedData
@@ -114,7 +114,7 @@ func (agent *Agent) processData(statsSlice []*client.Stats) (map[string]*interna
 }
 
 func (agent *Agent) handleErrorAndSleep(err error) {
-	log.Printf("Error while running the main loop: %v. No data will be sent this time, will try again in %d seconds", err, agent.cfg.RetryTime)
+	log.Printf("error while running the main loop: %v. No data will be sent this time, will try again in %d seconds", err, agent.cfg.RetryTime)
 	time.Sleep(time.Duration(agent.cfg.RetryTime) * time.Second)
 }
 
@@ -134,7 +134,7 @@ func (agent *Agent) Run() {
 
 		err = agent.pusher.Push(data)
 		if err != nil {
-			log.Printf("Error pushing the data: %v", err)
+			log.Printf("error pushing the data: %v", err)
 		}
 
 		sleepTime := int(agent.cfg.Interval)
@@ -161,7 +161,7 @@ func New(globalConfig *Config) (*Agent, error) {
 // merge an array of Stats fetched from one or more NGINX Plus instances focusing on the right stats depending on the configured methods
 func (agent *Agent) mergeStats(statsSlice []*client.Stats) (map[string]*internal.FeedData, error) {
 	if len(statsSlice) == 0 {
-		return nil, fmt.Errorf("Error merging data: no data to merge, empty response")
+		return nil, fmt.Errorf("error merging data: no data to merge, empty response")
 	}
 
 	switch agent.services.Method {
@@ -173,7 +173,7 @@ func (agent *Agent) mergeStats(statsSlice []*client.Stats) (map[string]*internal
 		return getStatusZonesConnectionsData(statsSlice, agent.namedServices), nil
 	}
 
-	return nil, fmt.Errorf("Error processing the data from NGINX Plus instance(s): %v is not a valid NGINX Plus type", agent.services.Method)
+	return nil, fmt.Errorf("error processing the data from NGINX Plus instance(s): %v is not a valid NGINX Plus type", agent.services.Method)
 }
 
 func getGlobalConnectionsData(statsSlice []*client.Stats) map[string]*internal.FeedData {

internal/agent/agent_test.go

@@ -20,7 +20,7 @@ func TestNewAgentFailureNoNGINXPlus(t *testing.T) {
 	}
 	_, err := New(globalCfg)
 	if err == nil {
-		t.Errorf("Agent creation err returned %+v but expected an error because NGINX Plus is not reachable", err)
+		t.Errorf("agent creation err returned %+v but expected an error because NGINX Plus is not reachable", err)
 	}
 }
 
@@ -69,7 +69,7 @@ func TestProcessData(t *testing.T) {
 		agent.services.Method = testCase.nType
 		feedData, _ := agent.processData(testCase.input)
 		if !reflect.DeepEqual(testCase.expected, feedData) {
-			t.Errorf("Agent.processData returned %v, but %v expected for case: %v", feedData, testCase.expected, testCase.msg)
+			t.Errorf("agent.processData returned %v, but %v expected for case: %v", feedData, testCase.expected, testCase.msg)
 		}
 	}
 }

internal/agent/configurator.go

@@ -29,43 +29,43 @@ type Config struct {
 func ParseConfig(path *string) (*Config, error) {
 	data, err := ioutil.ReadFile(*path)
 	if err != nil {
-		return nil, fmt.Errorf("Error reading file at %v: %w", path, err)
+		return nil, fmt.Errorf("error reading file at %v: %w", path, err)
 	}
 
 	globalConfig := &Config{}
 	err = yaml.Unmarshal(data, globalConfig)
 	if err != nil {
-		return nil, fmt.Errorf("Error while parsing the configuration file: %w", err)
+		return nil, fmt.Errorf("error while parsing the configuration file: %w", err)
 	}
 
 	globalConfig = fillWithDefaults(globalConfig)
 
 	err = validateServicesCfg(globalConfig)
 	if err != nil {
-		return nil, fmt.Errorf("Error while validating Services configuration: %w", err)
+		return nil, fmt.Errorf("error while validating Services configuration: %w", err)
 	}
 
 	return globalConfig, nil
 }
 
 func validateServicesCfg(cfg *Config) error {
 	if len(cfg.Services.Feeds) == 0 {
-		return fmt.Errorf("At least 1 Feed needs to be defined")
+		return fmt.Errorf("at least 1 Feed needs to be defined")
 	}
 
 	if cfg.Services.SamplingType != mergeAvg && cfg.Services.SamplingType != mergeCount {
-		return fmt.Errorf("Sampling Type [%v] is not a valid type. Valid Sampling Types are: %v, %v", cfg.Services.SamplingType, mergeAvg, mergeCount)
+		return fmt.Errorf("sampling Type [%v] is not a valid type. Valid Sampling Types are: %v, %v", cfg.Services.SamplingType, mergeAvg, mergeCount)
 	}
 
 	names := make(map[string]bool)
 	for _, feed := range cfg.Services.Feeds {
 		if feed.FeedName == "" {
-			return fmt.Errorf("Feeds must define at least a feed_name")
+			return fmt.Errorf("feeds must define at least a feed_name")
 		}
 
 		if cfg.Services.Method != globalMethod {
 			if feed.Name == "" {
-				return fmt.Errorf("Feeds must define a name for method: %v", cfg.Services.Method)
+				return fmt.Errorf("feeds must define a name for method: %v", cfg.Services.Method)
 			}
 
 			if _, ok := names[feed.Name]; ok {

internal/input/nginx.go

@@ -77,7 +77,7 @@ func (n *NginxPlus) Fetch() []*client.Stats {
 	var statsSlice []*client.Stats
 	for _, task := range finishedTasks {
 		if task.err != nil {
-			log.Printf("Error fetching from NGINX Plus instance: %v", task.err)
+			log.Printf("error fetching from NGINX Plus instance: %v", task.err)
 		} else {
 			statsSlice = append(statsSlice, task.result)
 		}
@@ -88,7 +88,7 @@ func (n *NginxPlus) Fetch() []*client.Stats {
 // Configure sets the configuration of the NginxPlus clients
 func (n *NginxPlus) Configure(cfg *Cfg) error {
 	if len(cfg.Hosts) == 0 {
-		return fmt.Errorf("The NGINX Plus Fetcher requires at least 1 host to be defined")
+		return fmt.Errorf("the NGINX Plus Fetcher requires at least 1 host to be defined")
 	}
 	n.Cfg = cfg
 	var resolvedHosts []NginxHost

internal/input/resolver_test.go

@@ -11,11 +11,11 @@ func TestResolverLookup(t *testing.T) {
 	addrs, err := resolver.Lookup(host)
 
 	if len(addrs) == 0 {
-		t.Errorf("Resolver didn't return any address for host %v", host)
+		t.Errorf("resolver didn't return any address for host %v", host)
 	}
 
 	if err != nil {
-		t.Errorf("Error trying to resolve %v: %v", host, err)
+		t.Errorf("error trying to resolve %v: %v", host, err)
 	}
 }
 

internal/output/ns1.go

@@ -46,11 +46,11 @@ func (ns1 *NS1) Push(data map[string]*internal.FeedData) error {
 // Configure sets the configuration for the NS1 client
 func (ns1 *NS1) Configure(cfg *Cfg) error {
 	if cfg.APIKey == "" {
-		return fmt.Errorf("The NS1 Pusher requires an API KEY to be defined")
+		return fmt.Errorf("the NS1 Pusher requires an API KEY to be defined")
 	}
 
 	if cfg.SourceID == "" {
-		return fmt.Errorf("The NS1 Pusher requires a SourceID to be defined")
+		return fmt.Errorf("the NS1 Pusher requires a SourceID to be defined")
 	}
 
 	ns1.Cfg = cfg