Skip to content

Refactor packages #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pleshakov opened this issue Jun 2, 2023 Discussed in #707 · 0 comments · Fixed by #839
Closed

Refactor packages #709

pleshakov opened this issue Jun 2, 2023 Discussed in #707 · 0 comments · Fixed by #839
Assignees
Labels
refined Requirements are refined and the issue is ready to be implemented. tech-debt Short-term pain, long-term benefit
Milestone

Comments

@pleshakov
Copy link
Contributor

Discussed in #707

Originally posted by pleshakov June 1, 2023

After provisioner mode related code was merged 1df6bcd , we have 2 components in the internal package:

  • provisioner mode
  • static mode

Additionally, we have shared "framework" code that both provisioner and static mode use.

To reflect that, for better code organization, refactor the packages as below:

- internal
  - provisonermode
     - manager.go
     ... other files
  - staticmode
     - manager.go
     - nginx
     - state
     - status // status-related code, only relevant for static mode
  - framework // common framework code
    - events
    - controller
    - helpers
    - status // general purpose status-related code, both relevant for provisioner and static mode

As part of it, refactor the status package into two package, so that the one in framework/status doesn't depend on the graph.

@pleshakov pleshakov added the tech-debt Short-term pain, long-term benefit label Jun 2, 2023
@mpstefan mpstefan added this to the v0.5.0 milestone Jun 29, 2023
@mpstefan mpstefan added the refined Requirements are refined and the issue is ready to be implemented. label Jul 5, 2023
@kate-osborn kate-osborn self-assigned this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refined Requirements are refined and the issue is ready to be implemented. tech-debt Short-term pain, long-term benefit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants