Skip to content

Update unit tests to use new test Context #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sjberman opened this issue Feb 21, 2025 · 2 comments
Open

Update unit tests to use new test Context #3157

sjberman opened this issue Feb 21, 2025 · 2 comments
Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses. good first issue Good for newcomers tech-debt Short-term pain, long-term benefit tests Pull requests that update tests

Comments

@sjberman
Copy link
Collaborator

As of Go 1.24, the testing package provides a t.Context method that creates a context that is canceled once a test completes.

https://tip.golang.org/doc/go1.24#testingpkgtesting

Acceptance

  • update unit tests to use new testing.Context instead of the various context.TODO and context.Background, etc, that we currently use
@sjberman sjberman added tech-debt Short-term pain, long-term benefit tests Pull requests that update tests good first issue Good for newcomers labels Feb 21, 2025
@sindhushiv sindhushiv added the backlog Currently unprioritized work. May change with user feedback or as the product progresses. label Mar 4, 2025
@faustind
Copy link

faustind commented May 3, 2025

Hi @sjberman

I'm keen to take on this task if there's no one working on it yet.

@sjberman
Copy link
Collaborator Author

sjberman commented May 5, 2025

Hi @faustind, thanks for your interest! We're currently re-architecting our code a bit, which will result in some tests being removed and some being changed. I'd recommend keeping an eye on #3318, and once that is merged in, then you can pick up this story! Just don't want you to start on it and then have to restart again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Currently unprioritized work. May change with user feedback or as the product progresses. good first issue Good for newcomers tech-debt Short-term pain, long-term benefit tests Pull requests that update tests
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants