Skip to content

Commit fdfbb04

Browse files
authored
Remove Redundant bitwise operations (#13094)
Motivation: inverseMask is redundant since we will rightShift it with exact same amount Modifications: removed redundant operations Result: clean up
1 parent f027fa2 commit fdfbb04

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

buffer/src/main/java/io/netty/buffer/SizeClasses.java

+2-6
Original file line numberDiff line numberDiff line change
@@ -338,9 +338,7 @@ public int size2SizeIdx(int size) {
338338
int log2Delta = x < LOG2_SIZE_CLASS_GROUP + LOG2_QUANTUM + 1
339339
? LOG2_QUANTUM : x - LOG2_SIZE_CLASS_GROUP - 1;
340340

341-
int deltaInverseMask = -1 << log2Delta;
342-
int mod = (size - 1 & deltaInverseMask) >> log2Delta &
343-
(1 << LOG2_SIZE_CLASS_GROUP) - 1;
341+
int mod = size - 1 >> log2Delta & (1 << LOG2_SIZE_CLASS_GROUP) - 1;
344342

345343
return group + mod;
346344
}
@@ -371,9 +369,7 @@ private int pages2pageIdxCompute(int pages, boolean floor) {
371369
int log2Delta = x < LOG2_SIZE_CLASS_GROUP + pageShifts + 1?
372370
pageShifts : x - LOG2_SIZE_CLASS_GROUP - 1;
373371

374-
int deltaInverseMask = -1 << log2Delta;
375-
int mod = (pageSize - 1 & deltaInverseMask) >> log2Delta &
376-
(1 << LOG2_SIZE_CLASS_GROUP) - 1;
372+
int mod = pageSize - 1 >> log2Delta & (1 << LOG2_SIZE_CLASS_GROUP) - 1;
377373

378374
int pageIdx = group + mod;
379375

0 commit comments

Comments
 (0)