Skip to content

fix: follow-up to split-api revalidate behaviour #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2023

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented May 15, 2023

Summary

Follow-up, addresses the comments from #2058 (comment).

Test plan

  1. Visit the Deploy Preview (insert link to specific page) ...

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 4bc8d93
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/6461dd10f6a258000943db91
😎 Deploy Preview https://deploy-preview-2113--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 4bc8d93
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/6461dd10c41fbc00077a13ba
😎 Deploy Preview https://deploy-preview-2113--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 4bc8d93
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/6461dd10c41fbc00077a13bf
😎 Deploy Preview https://deploy-preview-2113--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Skn0tt Skn0tt changed the title Split api revalidate followup fix: follow-up to split-api revalidate behaviour May 15, 2023
@github-actions github-actions bot added the type: bug code to address defects in shipped code label May 15, 2023
@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 4bc8d93
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/6461dd100e3a050007d189a2
😎 Deploy Preview https://deploy-preview-2113--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 4bc8d93
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/6461dd11019f4c000873c09f
😎 Deploy Preview https://deploy-preview-2113--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 4bc8d93
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/6461dd100e3a050007d1899d
😎 Deploy Preview https://deploy-preview-2113--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 4bc8d93
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/6461dd10f6a258000943db96
😎 Deploy Preview https://deploy-preview-2113--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 4bc8d93
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/6461dd10c0273e0007d6655a
😎 Deploy Preview https://deploy-preview-2113--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 4bc8d93
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/6461dd10cf86e70008470e6a
😎 Deploy Preview https://deploy-preview-2113--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@orinokai orinokai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@Skn0tt Skn0tt merged commit cce048a into main May 15, 2023
@Skn0tt Skn0tt deleted the split-api-revalidate-followup branch May 15, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants