feat: add Generator to edge functions #2019
Conversation
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
type: feature
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Ended up having to sort the manifest data so that the snapshots would match. |
There was a problem hiding this comment.
Some more snapshots need an update: https://github.com/netlify/next-runtime/actions/runs/4725240207/jobs/8383749771?pr=2019#step:6:3932
test/index.spec.js
Outdated
| const manifestPath = await readJson(path.resolve('.netlify/edge-functions/manifest.json')) | ||
| const manifest = manifestPath.functions.sort() | ||
|
|
||
| expect(manifest).toMatchSnapshot() |
There was a problem hiding this comment.
I think we're overusing snapshots in most of our tests, for me it's typically the last resort.
I'd use this instead:
expect(manifest).toEqual(
expect.arrayContaining([
expect.objectContaining({
generator: '@netlify/[email protected]'
})
])
)This way it's instantly clear what we want to assert + you don't have to look at a snapshot file + you don't need to worry about other properties on the objects (which should be tested somewhere already)
Applies also to the test below.
You then can also drop the sort() as the order is not relevant anymore.
Some reading: https://www.emgoto.com/jest-partial-match/
There was a problem hiding this comment.
This is really helpful, thanks Lennart!!
Summary
This PR inputs the runtime version into the new generator field within edge-functions to aid in observability.
Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.