fix: check for middleware manifest before providing to Object.keys (#1559)

sarahetter · web-flow · commit f500f516281e · 2022-08-18T17:28:06.000Z
* fix: check for middleware manifest before providing to Object.keys

* fix: add second check for middlewareManifest.middleware
diff --git a/packages/runtime/src/index.ts b/packages/runtime/src/index.ts
@@ -85,7 +85,7 @@ const plugin: NetlifyPlugin = {
 
     let usingEdge = false
 
-    if (Object.keys(middlewareManifest?.functions).length !== 0) {
+    if (middlewareManifest?.functions && Object.keys(middlewareManifest.functions).length !== 0) {
       usingEdge = true
       if (process.env.NEXT_DISABLE_NETLIFY_EDGE) {
         failBuild(outdent`
@@ -95,7 +95,7 @@ const plugin: NetlifyPlugin = {
       }
     }
 
-    if (Object.keys(middlewareManifest?.middleware).length !== 0) {
+    if (middlewareManifest?.middleware && Object.keys(middlewareManifest.middleware).length !== 0) {
       usingEdge = true
       if (process.env.NEXT_DISABLE_NETLIFY_EDGE) {
         console.log(

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ const plugin: NetlifyPlugin = {`
`85`	`85`
`86`	`86`	`let usingEdge = false`
`87`	`87`
`88`		`- if (Object.keys(middlewareManifest?.functions).length !== 0) {`
	`88`	`+ if (middlewareManifest?.functions && Object.keys(middlewareManifest.functions).length !== 0) {`
`89`	`89`	`usingEdge = true`
`90`	`90`	`if (process.env.NEXT_DISABLE_NETLIFY_EDGE) {`
`91`	`91`	failBuild(outdent`
`@@ -95,7 +95,7 @@ const plugin: NetlifyPlugin = {`
`95`	`95`	`}`
`96`	`96`	`}`
`97`	`97`
`98`		`- if (Object.keys(middlewareManifest?.middleware).length !== 0) {`
	`98`	`+ if (middlewareManifest?.middleware && Object.keys(middlewareManifest.middleware).length !== 0) {`
`99`	`99`	`usingEdge = true`
`100`	`100`	`if (process.env.NEXT_DISABLE_NETLIFY_EDGE) {`
`101`	`101`	`console.log(`