fix: strip internal middleware header from responses (#160)

Author: ascorbic

edge-runtime/lib/response.ts

@@ -139,6 +139,7 @@ export const buildResponse = async ({
   }
 
   if (res.headers.get('x-middleware-next') === '1') {
+    res.headers.delete('x-middleware-next')
     return addMiddlewareHeaders(context.next(), res)
   }
   return res

src/run/handlers/server.ts

@@ -66,7 +66,7 @@ export default async (request: Request) => {
   // The side effect is that responses which do contain data will not be streamed to the client,
   // but that's fine for redirects.
   // TODO: Remove once a fix has been rolled out.
-  if (response.status > 300 && response.status < 400) {
+  if ((response.status > 300 && response.status < 400) || response.status >= 500) {
     const body = await response.text()
     return new Response(body || null, response)
   }

tests/netlify-e2e.json

@@ -116,14 +116,25 @@
     "test/e2e/basepath.test.ts": {
       "flakey": [
         "basePath should not update URL for a 404",
-        "basePath should handle 404 urls that start with basePath"
+        "basePath should handle 404 urls that start with basePath",
+        "basePath should show 404 for page not under the /docs prefix"
       ]
     },
     "test/e2e/app-dir/app/index.test.ts": {
       "flakey": [
         "app dir - basic should return the `vary` header from edge runtime",
         "app dir - basic should return the `vary` header from pages for flight requests"
       ]
+    },
+    "test/e2e/app-dir/conflicting-page-segments/conflicting-page-segments.test.ts": {
+      "flakey": [
+        "conflicting-page-segments should throw an error when a route groups causes a conflict with a parallel segment"
+      ]
+    },
+    "test/e2e/app-dir/actions-navigation/index.test.ts": {
+      "flakey": [
+        "app-dir action handling should handle actions correctly after following a relative link"
+      ]
     }
   },
   "rules": {
@@ -168,7 +179,8 @@
       "test/e2e/trailingslash-with-rewrite/index.test.ts",
       "test/e2e/transpile-packages/index.test.ts",
       "test/e2e/typescript-version-no-warning/typescript-version-no-warning.test.ts",
-      "test/e2e/typescript-version-warning/typescript-version-warning.test.ts"
+      "test/e2e/typescript-version-warning/typescript-version-warning.test.ts",
+      "test/e2e/app-dir/app/useReportWebVitals.test.ts"
     ]
   }
 }