feat: cache redirects for 60 seconds if no ttl provided (#1677)

orinokai · web-flow · commit 23d8d3b8fd22 · 2022-10-12T13:07:26.000Z
diff --git a/packages/runtime/src/templates/getHandler.ts b/packages/runtime/src/templates/getHandler.ts
@@ -131,8 +131,9 @@ const makeHandler = (conf: NextConfig, app, pageRoot, staticManifest: Array<[str
           // ODBs currently have a minimum TTL of 60 seconds
           result.ttl = Math.max(ttl, 60)
         }
-        // Only cache 404s ephemerally
-        if (ttl === ONE_YEAR_IN_SECONDS && result.statusCode === 404) {
+        const ephemeralCodes = [301, 302, 307, 308, 404]
+        if (ttl === ONE_YEAR_IN_SECONDS && ephemeralCodes.includes(result.statusCode)) {
+          // Only cache for 60s if default TTL provided
           result.ttl = 60
         }
         if (result.ttl > 0) {

Original file line number	Diff line number	Diff line change
`@@ -131,8 +131,9 @@ const makeHandler = (conf: NextConfig, app, pageRoot, staticManifest: Array<[str`
`131`	`131`	`// ODBs currently have a minimum TTL of 60 seconds`
`132`	`132`	`result.ttl = Math.max(ttl, 60)`
`133`	`133`	`}`
`134`		`- // Only cache 404s ephemerally`
`135`		`- if (ttl === ONE_YEAR_IN_SECONDS && result.statusCode === 404) {`
	`134`	`+ const ephemeralCodes = [301, 302, 307, 308, 404]`
	`135`	`+ if (ttl === ONE_YEAR_IN_SECONDS && ephemeralCodes.includes(result.statusCode)) {`
	`136`	`+ // Only cache for 60s if default TTL provided`
`136`	`137`	`result.ttl = 60`
`137`	`138`	`}`
`138`	`139`	`if (result.ttl > 0) {`