add custom headers test

Author: lindsaylevine

lib/steps/setupHeaders.js

@@ -18,17 +18,12 @@ const setupHeaders = (publishPath) => {
   headers.push("# Next-on-Netlify Headers");
 
   // Add rule to override cache control for static chunks
+  const indentNewLine = (s) => `\n  ${s}`;
   const staticChunkRule = [
     `/*/_next/static/chunks/*`,
-    `\n`,
-    `  `,
-    `cache-control: public`,
-    `\n`,
-    `  `,
-    `cache-control: max-age=31536000`,
-    `\n`,
-    `  `,
-    `cache-control: immutable`,
+    indentNewLine(`cache-control: public`),
+    indentNewLine(`cache-control: max-age=31536000`),
+    indentNewLine(`cache-control: immutable`),
   ].join("");
   headers.push(staticChunkRule);
 

tests/customHeaders.test.js

@@ -0,0 +1,51 @@
+// Test next-on-netlify when a custom distDir is set in next.config.js
+
+const { EOL } = require("os");
+const { parse, join } = require("path");
+const { readFileSync } = require("fs-extra");
+const buildNextApp = require("./helpers/buildNextApp");
+
+// The name of this test file (without extension)
+const FILENAME = parse(__filename).name;
+
+// The directory which will be used for testing.
+// We simulate a NextJS app within that directory, with pages, and a
+// package.json file.
+const PROJECT_PATH = join(__dirname, "builds", FILENAME);
+
+// Capture the output to verify successful build
+let buildOutput;
+
+beforeAll(
+  async () => {
+    buildOutput = await buildNextApp()
+      .forTest(__filename)
+      .withPages("pages-with-static-props-index")
+      .withNextConfig("next.config.js")
+      .withPackageJson("package.json")
+      .withFile("_headers")
+      .build();
+  },
+  // time out after 180 seconds
+  180 * 1000
+);
+
+describe("next-on-netlify", () => {
+  test("builds successfully", () => {
+    expect(buildOutput).toMatch("Next on Netlify");
+    expect(buildOutput).toMatch("Success! All done!");
+  });
+});
+
+describe("Headers", () => {
+  test("includes custom header rules", async () => {
+    // Read _redirects file
+    const contents = readFileSync(
+      join(PROJECT_PATH, "out_publish", "_headers"),
+      "utf8"
+    );
+
+    const headers = contents.trim().split(EOL);
+    expect(headers[0]).toEqual("/templates/index.html");
+  });
+});

tests/fixtures/_headers

@@ -0,0 +1,8 @@
+/templates/index.html
+  # headers for that path:
+  X-Frame-Options: DENY
+  X-XSS-Protection: 1; mode=block
+
+/templates/index2.html
+  # headers for that path:
+  X-Frame-Options: SAMEORIGIN