Skip to content

fix: explicitly type image config in ipx edge function #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2022
Merged

fix: explicitly type image config in ipx edge function #1457

merged 1 commit into from
Jul 12, 2022

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Jul 12, 2022 •
edited
Loading

Summary

Explicitly type the imageconfig.json in the ipx content negotiation edge function. This fixes a bundling error in the case where the Next config is missing the formats key, meaning the inferred type was invalid.

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

baby capybara

@ascorbic ascorbic requested a review from a team July 12, 2022 08:34
@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit f3b2feb
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62cd3200c800d8000851917e
😎 Deploy Preview https://deploy-preview-1457--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for next-hp-edge-demo ready!

Name Link
🔨 Latest commit f3b2feb
🔍 Latest deploy log https://app.netlify.com/sites/next-hp-edge-demo/deploys/62cd3201a70ab50008936722
😎 Deploy Preview https://deploy-preview-1457--next-hp-edge-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit f3b2feb
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62cd3200c800d80008519179
😎 Deploy Preview https://deploy-preview-1457--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit f3b2feb
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62cd3200586ed10008f863fa
😎 Deploy Preview https://deploy-preview-1457--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit f3b2feb
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/62cd32008b6eed0009d1c258
😎 Deploy Preview https://deploy-preview-1457--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jul 12, 2022
@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit f3b2feb
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/62cd320190733b0007e3d677
😎 Deploy Preview https://deploy-preview-1457--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

❌ Deploy Preview for next-plugin-rsc-demo failed.

Name Link
🔨 Latest commit f3b2feb
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62cd32015cc82e000815b53b

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit f3b2feb
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/62cd3201845727000860cd22
😎 Deploy Preview https://deploy-preview-1457--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit f3b2feb
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/62cd320123016e000838784f
😎 Deploy Preview https://deploy-preview-1457--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit f3b2feb
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/62cd32018b6eed0009d1c262
😎 Deploy Preview https://deploy-preview-1457--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Jul 12, 2022


Test summary

22 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-default-demo
Status Passed
Commit c27ff21 ℹ️
Started Jul 12, 2022 8:37 AM
Ended Jul 12, 2022 8:38 AM
Duration 01:35 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jul 12, 2022


Test summary

7 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-static-demo
Status Passed
Commit c27ff21 ℹ️
Started Jul 12, 2022 8:37 AM
Ended Jul 12, 2022 8:39 AM
Duration 01:29 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jul 12, 2022


Test summary

2 • 0 • 0 • 0

Run details
Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit c27ff21 ℹ️
Started Jul 12, 2022 8:38 AM
Ended Jul 12, 2022 8:40 AM
Duration 01:22 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

MarcL
MarcL approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@MarcL MarcL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kodiakhq kodiakhq bot merged commit a96af92 into main Jul 12, 2022
@kodiakhq kodiakhq bot deleted the mk/edge-ipx-fix branch July 12, 2022 08:57
@token-generator-app token-generator-app bot mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcL MarcL MarcL approved these changes

Assignees
No one assigned
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascorbic @MarcL