fix: handle missing manifest functions field #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kodiakhq merged 1 commit into main from mk/manifest-func-check

Jun 24, 2022

Contributor

ascorbic commented Jun 24, 2022

Summary

Fix to problem building sites in versions of Next which don't define functions in middleware manifest

Test plan

Visit the Deploy Preview (insert link to specific page) ...

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

Check the Deploy Preview's Demo site for your PR's functionality
Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.


          fix: handle missing manifest functions field

62f5bd8

ascorbic requested a review from a team

June 24, 2022 07:12

netlify bot commented Jun 24, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name	Link
🔨 Latest commit	`62f5bd8`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/62b563d496f77f00094cac1e
😎 Deploy Preview	https://deploy-preview-1416--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Jun 24, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name	Link
🔨 Latest commit	`62f5bd8`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/62b563d4b60c1a00093e6ed2
😎 Deploy Preview	https://deploy-preview-1416--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Jun 24, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name	Link
🔨 Latest commit	`62f5bd8`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/62b563d492ae090008ed73dd
😎 Deploy Preview	https://deploy-preview-1416--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Jun 24, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

Name	Link
🔨 Latest commit	`62f5bd8`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/62b563d4aaa93000080c10eb
😎 Deploy Preview	https://deploy-preview-1416--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions bot added the type: bug label

netlify bot commented Jun 24, 2022 •

edited

Loading

✅ Deploy Preview for next-plugin-rsc-demo ready!

Name	Link
🔨 Latest commit	`62f5bd8`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/62b563d4b60c1a00093e6ed7
😎 Deploy Preview	https://deploy-preview-1416--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Jun 24, 2022 •

edited

Loading

✅ Deploy Preview for next-i18next-demo ready!

Name	Link
🔨 Latest commit	`62f5bd8`
🔍 Latest deploy log	https://app.netlify.com/sites/next-i18next-demo/deploys/62b563d4c071d200083c4d91
😎 Deploy Preview	https://deploy-preview-1416--next-i18next-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Jun 24, 2022 •

edited

Loading

✅ Deploy Preview for next-plugin-canary ready!

Name	Link
🔨 Latest commit	`62f5bd8`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-canary/deploys/62b563d4b8fdf100090becf8
😎 Deploy Preview	https://deploy-preview-1416--next-plugin-canary.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Jun 24, 2022 •

edited

Loading

✅ Deploy Preview for next-plugin-edge-middleware ready!

Name	Link
🔨 Latest commit	`62f5bd8`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/62b563d49c89ef00096b8400
😎 Deploy Preview	https://deploy-preview-1416--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify bot commented Jun 24, 2022 •

edited

Loading

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name	Link
🔨 Latest commit	`62f5bd8`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/62b563d4609ced000852575e
😎 Deploy Preview	https://deploy-preview-1416--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cypress bot commented Jun 24, 2022

Test summary

7 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-static-demo
Status	Passed
Commit	`8dc8386` ℹ️
Started	Jun 24, 2022 7:15 AM
Ended	Jun 24, 2022 7:16 AM
Duration	01:14 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 102

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress bot commented Jun 24, 2022

Test summary

21 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-default-demo
Status	Passed
Commit	`8dc8386` ℹ️
Started	Jun 24, 2022 7:15 AM
Ended	Jun 24, 2022 7:17 AM
Duration	01:33 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 102

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress bot commented Jun 24, 2022

Test summary

2 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-nx-monorepo-demo
Status	Passed
Commit	`8dc8386` ℹ️
Started	Jun 24, 2022 7:16 AM
Ended	Jun 24, 2022 7:17 AM
Duration	01:10 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 102

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

orinokai approved these changes

View reviewed changes

Contributor

orinokai left a comment

ascorbic added the automerge label

kodiakhq bot merged commit 5114193 into main

kodiakhq bot deleted the mk/manifest-func-check branch

June 24, 2022 08:23

token-generator-app bot mentioned this pull request

chore(main): release plugin-nextjs 4.9.3 #1417

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge type: bug