feat: Include basePath property in NEXTAUTH_URL when present in config #1336

ericapisani · 2022-05-02T14:35:38Z

Summary

This was missed in the initial implementation of adding out of the box NextAuth support (see #1242 ), but is something that is needed when the basePath property exists within the next.config.js file. Related docs on NextAuth can be found here

Test plan

Visit the Deploy Preview here

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

Check the Deploy Preview's Demo site for your PR's functionality

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

netlify · 2022-05-02T14:35:43Z

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

Name	Link
🔨 Latest commit	`f0f090d`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/6270035d2737b50008930f7b
😎 Deploy Preview	https://deploy-preview-1336--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-05-02T14:36:01Z

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name	Link
🔨 Latest commit	`f0f090d`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/6270035dc404870009654cc3
😎 Deploy Preview	https://deploy-preview-1336--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-05-02T14:36:01Z

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name	Link
🔨 Latest commit	`f0f090d`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/6270035ddffb650009b04f3c
😎 Deploy Preview	https://deploy-preview-1336--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-05-02T14:36:02Z

✅ Deploy Preview for next-plugin-edge-middleware canceled.

Name	Link
🔨 Latest commit	`f0f090d`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/6270035d3b5ec70008a1e62c

netlify · 2022-05-02T14:36:03Z

✅ Deploy Preview for next-plugin-rsc-demo canceled.

Name	Link
🔨 Latest commit	`f0f090d`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/6270035d150ff300087c5e83

netlify · 2022-05-02T14:36:04Z

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name	Link
🔨 Latest commit	`f0f090d`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/6270035d8eeb610008eb0f91
😎 Deploy Preview	https://deploy-preview-1336--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-05-02T14:36:05Z

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name	Link
🔨 Latest commit	`f0f090d`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/6270035da62f49000858347d
😎 Deploy Preview	https://deploy-preview-1336--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-05-02T14:36:14Z

✅ Deploy Preview for next-i18next-demo ready!

Name	Link
🔨 Latest commit	`f0f090d`
🔍 Latest deploy log	https://app.netlify.com/sites/next-i18next-demo/deploys/6270035d3c8372000cdc67c7
😎 Deploy Preview	https://deploy-preview-1336--next-i18next-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cypress · 2022-05-02T14:40:07Z

Test summary

7 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-static-demo
Status	Passed
Commit	`443a9f8` ℹ️
Started	May 2, 2022 4:17 PM
Ended	May 2, 2022 4:18 PM
Duration	01:13 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 100

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress · 2022-05-02T14:40:14Z

Test summary

22 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-default-demo
Status	Passed
Commit	`443a9f8` ℹ️
Started	May 2, 2022 4:17 PM
Ended	May 2, 2022 4:19 PM
Duration	01:39 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 100

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress · 2022-05-02T14:41:03Z

Test summary

2 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-nx-monorepo-demo
Status	Passed
Commit	`443a9f8` ℹ️
Started	May 2, 2022 4:18 PM
Ended	May 2, 2022 4:19 PM
Duration	01:09 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 100

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

nickytonline · 2022-05-02T15:56:23Z

@ericapisani, the demo site exited early during build.

11:05:54 AM: Build ready to start
11:06:00 AM: build-image version: d2c6dbeac570350a387d832f64bc980dc964ad65 (focal)
11:06:00 AM: build-image tag: v4.8.0
11:06:00 AM: buildbot version: a018caed2ab46726023e1532e0d3214727318b1c
11:06:00 AM: Fetching cached dependencies
11:06:01 AM: Starting to download cache of 239.1MB
11:06:03 AM: Finished downloading cache in 2.728393725s
11:06:03 AM: Starting to extract cache
11:06:07 AM: Finished extracting cache in 4.257576514s
11:06:07 AM: Finished fetching cache in 7.005896418s
11:06:07 AM: Starting to prepare the repo for build
11:06:08 AM: Preparing Git Reference pull/1336/head
11:06:08 AM: Parsing package.json dependencies
11:06:09 AM: Different publish path detected, going to use the one specified in the Netlify configuration file: 'demos/next-auth/.next' versus '.next' in the Netlify UI
11:06:09 AM: Different build command detected, going to use the one specified in the Netlify configuration file: 'next build' versus 'npm run build' in the Netlify UI
11:06:09 AM: Detected ignore command in Netlify configuration file. Proceeding with the specified command: 'git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF . ../../plugin'
11:06:09 AM: User-specified ignore command returned exit code 0. Returning early from build.
11:06:09 AM: Creating deploy upload records
11:06:09 AM: Failed during stage 'checking build content for changes': Canceled build due to no content change
11:06:09 AM: Finished processing build request in 8.965846734s

ericapisani · 2022-05-02T16:23:15Z

@nickytonline Not quite sure what happened but I'm seeing a successful build message 🤔

This is also the most recent build log on the Netlify UI side so maybe it was just an initial hiccup and merging the main branch into this branch was what it needed to sort itself out

sarahetter · 2022-05-02T16:27:03Z

I'm seeing the same thing as Erica, fwiw

nickytonline · 2022-05-02T17:28:55Z

@nickytonline Not quite sure what happened but I'm seeing a successful build message 🤔

This is also the most recent build log on the Netlify UI side so maybe it was just an initial hiccup and merging the main branch into this branch was what it needed to sort itself out

Weird, seems all good now. 🙃

nickytonline

Tested the demo site locally and it looks good. Same for tests. 🚀

ericapisani added 2 commits May 2, 2022 10:31

feat: handle custom base paths when creating NEXTAUTH_URL

917e4ce

style: lint

112a961

ericapisani self-assigned this May 2, 2022

github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label May 2, 2022

Merge branch 'main' into ep/include-basePath-in-nextAuth-url

b868d0b

ericapisani requested a review from a team May 2, 2022 15:13

ericapisani marked this pull request as ready for review May 2, 2022 15:13

Merge branch 'main' into ep/include-basePath-in-nextAuth-url

f0f090d

nickytonline approved these changes May 2, 2022

View reviewed changes

ericapisani added the automerge label May 2, 2022

kodiakhq bot merged commit 346aad1 into main May 2, 2022

kodiakhq bot deleted the ep/include-basePath-in-nextAuth-url branch May 2, 2022 21:48

token-generator-app bot mentioned this pull request May 2, 2022

chore(main): release plugin-nextjs 4.7.0 #1338

Merged

token-generator-app bot mentioned this pull request Jun 14, 2022

chore(main): release plugin-nextjs 4.10.0 #1393

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Include basePath property in NEXTAUTH_URL when present in config #1336

feat: Include basePath property in NEXTAUTH_URL when present in config #1336

ericapisani commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

cypress bot commented May 2, 2022 •

edited

Loading

cypress bot commented May 2, 2022 •

edited

Loading

cypress bot commented May 2, 2022 •

edited

Loading

nickytonline commented May 2, 2022

ericapisani commented May 2, 2022

sarahetter commented May 2, 2022

nickytonline commented May 2, 2022

nickytonline left a comment

feat: Include basePath property in NEXTAUTH_URL when present in config #1336

feat: Include basePath property in NEXTAUTH_URL when present in config #1336

Conversation

ericapisani commented May 2, 2022 • edited Loading

Summary

Test plan

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

netlify bot commented May 2, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

netlify bot commented May 2, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

netlify bot commented May 2, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

netlify bot commented May 2, 2022 • edited Loading

✅ Deploy Preview for next-plugin-edge-middleware canceled.

netlify bot commented May 2, 2022 • edited Loading

✅ Deploy Preview for next-plugin-rsc-demo canceled.

netlify bot commented May 2, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

netlify bot commented May 2, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

netlify bot commented May 2, 2022 • edited Loading

✅ Deploy Preview for next-i18next-demo ready!

cypress bot commented May 2, 2022 • edited Loading

Test summary

Run details

cypress bot commented May 2, 2022 • edited Loading

Test summary

Run details

cypress bot commented May 2, 2022 • edited Loading

Test summary

Run details

nickytonline commented May 2, 2022

ericapisani commented May 2, 2022

sarahetter commented May 2, 2022

nickytonline commented May 2, 2022

nickytonline left a comment

Choose a reason for hiding this comment

ericapisani commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

cypress bot commented May 2, 2022 •

edited

Loading

cypress bot commented May 2, 2022 •

edited

Loading

cypress bot commented May 2, 2022 •

edited

Loading