feat: Add support for next-i18next #1331

sarahetter · 2022-04-27T19:42:38Z

Summary

Adds support for next-i18next out of the box by including the locale files (public/locales/**) and next-i18next.config.js

Test plan

Visit the Deploy Preview (https://next-i18next-test.netlify.app/)

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Closes #1241

Standard checks:

Check the Deploy Preview's Demo site for your PR's functionality
Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

netlify · 2022-04-27T19:42:44Z

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

Name	Link
🔨 Latest commit	`28b796f`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/626ae7fca7f6c10009362cf3
😎 Deploy Preview	https://deploy-preview-1331--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-04-27T19:42:45Z

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name	Link
🔨 Latest commit	`28b796f`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/626ae7fc2865fb00098979f1
😎 Deploy Preview	https://deploy-preview-1331--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-04-27T19:43:52Z

✅ Deploy Preview for next-plugin-edge-middleware canceled.

Name	Link
🔨 Latest commit	`28b796f`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/626ae7fc74c681000800e419

netlify · 2022-04-27T19:43:53Z

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name	Link
🔨 Latest commit	`28b796f`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/626ae7fcc88062000818edca
😎 Deploy Preview	https://deploy-preview-1331--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-04-27T19:43:53Z

✅ Deploy Preview for next-plugin-rsc-demo canceled.

Name	Link
🔨 Latest commit	`28b796f`
🔍 Latest deploy log	https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/626ae7fca7f6c10009362cf8

netlify · 2022-04-27T19:43:55Z

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name	Link
🔨 Latest commit	`28b796f`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/626ae7fc2865fb00098979f6
😎 Deploy Preview	https://deploy-preview-1331--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2022-04-27T19:43:59Z

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo canceled.

Name	Link
🔨 Latest commit	`28b796f`
🔍 Latest deploy log	https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/626ae7fca803ee0009bfcd30

sarahetter · 2022-04-27T19:45:07Z

test/index.js

@@ -1,9 +1,9 @@
 jest.mock('../plugin/src/helpers/utils', () => {
  return {
-    ...(jest.requireActual('../plugin/src/helpers/utils')),
-    isNextAuthInstalled: jest.fn()
+    ...jest.requireActual('../plugin/src/helpers/utils'),


Extra noise in this file due to my autosave lint plugin. Good news is this file now follows our eslint and prettier rules 😅

cypress · 2022-04-27T19:47:07Z

Test summary

22 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-default-demo
Status	Passed
Commit	`d37d041` ℹ️
Started	Apr 28, 2022 7:19 PM
Ended	Apr 28, 2022 7:20 PM
Duration	01:34 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 100

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress · 2022-04-27T19:47:22Z

Test summary

2 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-nx-monorepo-demo
Status	Passed
Commit	`d37d041` ℹ️
Started	Apr 28, 2022 7:19 PM
Ended	Apr 28, 2022 7:21 PM
Duration	01:13 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 100

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress · 2022-04-27T19:48:05Z

Test summary

7 • 0 • 0 • 0

Run details


Project	netlify-plugin-nextjs-static-demo
Status	Passed
Commit	`d37d041` ℹ️
Started	Apr 28, 2022 7:19 PM
Ended	Apr 28, 2022 7:20 PM
Duration	01:28 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 100

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

ericapisani

This is overall looking great!

I had one question, and the only blocker to me approving (unless there's a strong reason not to) is we'll want to have a demo of this site deployed automatically as part of our continuous testing similar to what we have for the other demo sites.

demos/next-i18next/next.config.js

netlify · 2022-04-28T13:53:27Z

✅ Deploy Preview for next-i18next-demo canceled.

Name	Link
🔨 Latest commit	`28b796f`
🔍 Latest deploy log	https://app.netlify.com/sites/next-i18next-demo/deploys/626ae7fcc88062000818edcf

sarahetter · 2022-04-28T15:03:21Z

Demo site added at https://next-i18next-demo.netlify.app/, and this has been set up in app.netlify.com and is working correctly. ☺️

✅ Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 4f34543
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/626aa9ce1a20ad0008c5b8aa
😎 Deploy Preview https://deploy-preview-1331--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...
To edit notification comments on pull requests, go to your Netlify site settings.

nickytonline

[dust] Since this PR is for adding the next-i18next demo site, consider adding the non-related files to the next-i18next demo in another PR.

Aside from that looks good!

ericapisani

LGTM! 🚀

sarahetter added 5 commits April 27, 2022 15:25

chore: running npm install after version was updated in main

fc1ddc7

feat: add demo for internationalization

3b9338f

feat: add next-i18next files to included_files

6797f2e

test: add files to test

3cbd762

chore: remove readme

f8f075a

sarahetter requested a review from a team April 27, 2022 19:42

sarahetter self-assigned this Apr 27, 2022

github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Apr 27, 2022

sarahetter commented Apr 27, 2022

View reviewed changes

sarahetter added 2 commits April 27, 2022 16:17

chore: remove confusing lang in readmes

2c9b79d

chore: re-add accidentally deleted readme

d696ec9

ericapisani reviewed Apr 28, 2022

View reviewed changes

demos/next-i18next/next.config.js Show resolved Hide resolved

chore: add site url for demo

e4c2a53

sarahetter added 4 commits April 28, 2022 10:37

chore: force to always build so cypress runs work

389acf9

chore: remove redefined value

cb02927

chore: force new build with diff

c38c955

chore: prettier

4f34543

sarahetter requested a review from ascorbic April 28, 2022 15:03

sarahetter requested review from ericapisani and nickytonline April 28, 2022 15:03

nickytonline reviewed Apr 28, 2022

View reviewed changes

ericapisani approved these changes Apr 28, 2022

View reviewed changes

Merge branch 'main' into feat/next-i18next

28b796f

sarahetter added the automerge label Apr 28, 2022

kodiakhq bot merged commit 5780e6b into main Apr 28, 2022

kodiakhq bot deleted the feat/next-i18next branch April 28, 2022 19:22

token-generator-app bot mentioned this pull request Apr 28, 2022

chore(main): release plugin-nextjs 4.6.0 #1333

Merged

token-generator-app bot mentioned this pull request Jun 14, 2022

chore(main): release plugin-nextjs 4.10.0 #1393

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add support for next-i18next #1331

feat: Add support for next-i18next #1331

sarahetter commented Apr 27, 2022

netlify bot commented Apr 27, 2022 •

edited

Loading

netlify bot commented Apr 27, 2022 •

edited

Loading

netlify bot commented Apr 27, 2022 •

edited

Loading

netlify bot commented Apr 27, 2022 •

edited

Loading

netlify bot commented Apr 27, 2022 •

edited

Loading

netlify bot commented Apr 27, 2022 •

edited

Loading

netlify bot commented Apr 27, 2022 •

edited

Loading

sarahetter Apr 27, 2022

cypress bot commented Apr 27, 2022 •

edited

Loading

cypress bot commented Apr 27, 2022 •

edited

Loading

cypress bot commented Apr 27, 2022 •

edited

Loading

ericapisani left a comment •

edited

Loading

netlify bot commented Apr 28, 2022 •

edited

Loading

sarahetter commented Apr 28, 2022

✅ Deploy Preview for next-i18next-demo ready!

nickytonline left a comment

ericapisani left a comment

feat: Add support for next-i18next #1331

feat: Add support for next-i18next #1331

Conversation

sarahetter commented Apr 27, 2022

Summary

Test plan

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

netlify bot commented Apr 27, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-demo ready!

netlify bot commented Apr 27, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

netlify bot commented Apr 27, 2022 • edited Loading

✅ Deploy Preview for next-plugin-edge-middleware canceled.

netlify bot commented Apr 27, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

netlify bot commented Apr 27, 2022 • edited Loading

✅ Deploy Preview for next-plugin-rsc-demo canceled.

netlify bot commented Apr 27, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!

netlify bot commented Apr 27, 2022 • edited Loading

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo canceled.

sarahetter Apr 27, 2022

Choose a reason for hiding this comment

cypress bot commented Apr 27, 2022 • edited Loading

Test summary

Run details

cypress bot commented Apr 27, 2022 • edited Loading

Test summary

Run details

cypress bot commented Apr 27, 2022 • edited Loading

Test summary

Run details

ericapisani left a comment • edited Loading

Choose a reason for hiding this comment

netlify bot commented Apr 28, 2022 • edited Loading

✅ Deploy Preview for next-i18next-demo canceled.

sarahetter commented Apr 28, 2022

✅ Deploy Preview for next-i18next-demo ready!

nickytonline left a comment

Choose a reason for hiding this comment

ericapisani left a comment

Choose a reason for hiding this comment

netlify bot commented Apr 27, 2022 •

edited

Loading

netlify bot commented Apr 27, 2022 •

edited

Loading

netlify bot commented Apr 27, 2022 •

edited

Loading

netlify bot commented Apr 27, 2022 •

edited

Loading

netlify bot commented Apr 27, 2022 •

edited

Loading

netlify bot commented Apr 27, 2022 •

edited

Loading

netlify bot commented Apr 27, 2022 •

edited

Loading

cypress bot commented Apr 27, 2022 •

edited

Loading

cypress bot commented Apr 27, 2022 •

edited

Loading

cypress bot commented Apr 27, 2022 •

edited

Loading

ericapisani left a comment •

edited

Loading

netlify bot commented Apr 28, 2022 •

edited

Loading