Skip to content

fix: include edge templates in the bundle #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Conversation

ascorbic
Copy link
Contributor

Summary

Add the src files into the package 🤦🏻

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit d190c15
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/625eba2c9264590008230695
😎 Deploy Preview https://deploy-preview-1317--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit d190c15
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/625eba2c1eb8ce00099f311d
😎 Deploy Preview https://deploy-preview-1317--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit d190c15
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/625eba2c41abc10008dfa8ab
😎 Deploy Preview https://deploy-preview-1317--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Apr 19, 2022
@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit d190c15
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/625eba2c41abc10008dfa8b0
😎 Deploy Preview https://deploy-preview-1317--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for next-plugin-edge-middleware canceled.

Name Link
🔨 Latest commit d190c15
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/625eba2c591a580008837a1b

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for next-plugin-rsc-demo canceled.

Name Link
🔨 Latest commit d190c15
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/625eba2c591a580008837a1d

@cypress
Copy link

cypress bot commented Apr 19, 2022



Test summary

0 7 0 0


Run details

Project netlify-plugin-nextjs-static-demo
Status Failed
Commit c4c8f1e ℹ️
Started Apr 19, 2022 1:36 PM
Ended Apr 19, 2022 1:37 PM
Duration 01:21 💡
OS Linux Ubuntu - 20.04
Browser Chrome 100

View run in Cypress Dashboard ➡️


Failures

i18n.spec.ts Failed
1 Localization > should use sub routing to determine current locale
2 Localization > should use the NEXT_LOCALE cookie to determine the default locale
3 Localization > should use the nf_lang cookie to determine the default locale
4 Localization > should use Accept-Language to choose a locale
5 Localization > should use the NEXT_LOCALE cookie over Accept-Language header to determine the default locale
rewrites-redirects.spec.ts Failed
1 Rewrites and Redirects > rewrites: points /old to /
2 Rewrites and Redirects > redirects: redirects /redirectme to /

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Apr 19, 2022



Test summary

0 21 0 1


Run details

Project netlify-plugin-nextjs-default-demo
Status Failed
Commit c4c8f1e ℹ️
Started Apr 19, 2022 1:36 PM
Ended Apr 19, 2022 1:38 PM
Duration 01:51 💡
OS Linux Ubuntu - 20.04
Browser Chrome 100

View run in Cypress Dashboard ➡️


Failures

i18n.spec.ts Failed
1 Localization > should use sub routing to determine current locale
2 Localization > should use the NEXT_LOCALE cookie to determine the default locale
3 Localization > should use the NEXT_LOCALE cookie over Accept-Language header to determine the default locale
rewrites-redirects.spec.ts Failed
1 Rewrites and Redirects > rewrites: points /old to /
2 Rewrites and Redirects > redirects: redirects /redirectme to /
custom-errors.spec.ts Failed
1 Custom error pages > should show custom 404 page on /404
2 Custom error pages > should show custom 500 page on /500
default.spec.ts Failed
1 Default site > loads home page
images.spec.ts Failed
1 next/images > should show static image from /public
2 next/images > should show image using next/image
This comment includes only the first 10 test failures. See all 21 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Apr 19, 2022



Test summary

1 1 0 0


Run details

Project netlify-plugin-nextjs-nx-monorepo-demo
Status Failed
Commit c4c8f1e ℹ️
Started Apr 19, 2022 1:37 PM
Ended Apr 19, 2022 1:40 PM
Duration 02:56 💡
OS Linux Ubuntu - 20.04
Browser Chrome 100

View run in Cypress Dashboard ➡️


Failures

cypress/integration/nx/general.spec.ts Failed
1 Default site > loads home page

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kodiakhq kodiakhq bot merged commit b9d3abf into main Apr 19, 2022
@kodiakhq kodiakhq bot deleted the mk/include-src-templates branch April 19, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants