Skip to content

fix: copy edge src file #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2022
Merged

fix: copy edge src file #1315

merged 3 commits into from
Apr 19, 2022

Conversation

ascorbic
Copy link
Contributor

Summary

Ensure that edge functions use the source TypeScript, rather than compiled js. Fixes the toml to ensure the env is properly set

Test plan

  1. Ensure the middleware demo builds correctly

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit 430dcb6
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/625ea2f33a0e400008f7f945
😎 Deploy Preview https://deploy-preview-1315--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit 430dcb6
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/625ea2f3a804fc000935e64b
😎 Deploy Preview https://deploy-preview-1315--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for netlify-plugin-nextjs-demo canceled.

Name Link
🔨 Latest commit 430dcb6
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/625ea2f3e542850008e688ec

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit 430dcb6
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/625ea2f3b070c70009b999be
😎 Deploy Preview https://deploy-preview-1315--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ascorbic ascorbic requested a review from a team April 19, 2022 11:46
@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit 430dcb6
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/625ea2f38961de0008fc7a19
😎 Deploy Preview https://deploy-preview-1315--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 430dcb6
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/625ea5dbeb71a611b2071b0c
😎 Deploy Preview https://deploy-preview-1315--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Apr 19, 2022
@cypress
Copy link

cypress bot commented Apr 19, 2022



Test summary

7 0 0 0


Run details

Project netlify-plugin-nextjs-static-demo
Status Passed
Commit ce913ed ℹ️
Started Apr 19, 2022 11:57 AM
Ended Apr 19, 2022 11:58 AM
Duration 01:14 💡
OS Linux Ubuntu - 20.04
Browser Chrome 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Apr 19, 2022



Test summary

2 20 0 0


Run details

Project netlify-plugin-nextjs-default-demo
Status Failed
Commit ce913ed ℹ️
Started Apr 19, 2022 11:56 AM
Ended Apr 19, 2022 11:58 AM
Duration 01:53 💡
OS Linux Ubuntu - 20.04
Browser Chrome 100

View run in Cypress Dashboard ➡️


Failures

i18n.spec.ts Failed
1 Localization > should use sub routing to determine current locale
2 Localization > should use the NEXT_LOCALE cookie to determine the default locale
3 Localization > should use the NEXT_LOCALE cookie over Accept-Language header to determine the default locale
rewrites-redirects.spec.ts Failed
1 Rewrites and Redirects > rewrites: points /old to /
2 Rewrites and Redirects > redirects: redirects /redirectme to /
preview.spec.ts Failed
1 Preview Mode > enters and exits preview mode
default.spec.ts Failed
1 Default site > loads home page
2 Default site > sets NODE_ENV
images.spec.ts Failed
1 next/images > should show static image from /public
2 next/images > should show image using next/image
This comment includes only the first 10 test failures. See all 20 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Apr 19, 2022



Test summary

2 0 0 0


Run details

Project netlify-plugin-nextjs-nx-monorepo-demo
Status Passed
Commit ce913ed ℹ️
Started Apr 19, 2022 11:57 AM
Ended Apr 19, 2022 11:58 AM
Duration 01:10 💡
OS Linux Ubuntu - 20.04
Browser Chrome 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kodiakhq kodiakhq bot merged commit ccdb544 into main Apr 19, 2022
@kodiakhq kodiakhq bot deleted the mk/copy-correct-src branch April 19, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants